Support embed urls in the following format. This format is found in the Vidyard dashboard for the Embed Code > Developer "Share this link with your web developer".

{code}
https://secure.vidyard.com/embed_select/A1B_C2D345E-fg-hijKL6M
# Has embed_select endpoint.
# ID contains "_" and "-".
{code}

Comments

recrit created an issue. See original summary.

recrit’s picture

Status: Active » Needs review
StatusFileSize
new712 bytes

The attached patch updates the regex in getIdFromInput() to support the embed_select url.

recrit’s picture

eric115’s picture

Great patch!

I have added some unit tests in to check URL parsing.

eric115’s picture

Updating for drupal-ci to test these patches

eric115’s picture

  • Eric115 committed 31e97cf on 8.x-1.x
    Issue #2853635 by recrit, Eric115: Support embed codes for https://...
eric115’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed, thanks for your patch @recrit!

Marking this to be ported to the 7.x version

osman’s picture

This is an old issue now, but is embed_select still valid for sharable URLs?

The example URL in the description doesn't work anymore, also I couldn't find any reference to it in Vinyard documentations, except for the "Developer Web Embed" URL.

All the patterns I could find:

eric115’s picture

It's quite possible it's changed now. I haven't worked with vidyard for quite a while and this module was written a few years ago.

It might be worth creating a new issue for this change if you would like to patch it, I think you can still use the module by using the custom url options, but it would be good to update the examples if people are still using this module.