Right now this is a difficult module to work with outside of the Drupal GUI use case. I found I had to duplicate a lot of code from the .module file just to get the list of tags for a node (including defaults) into an API module, for example.
Attached a patch that adds default handling into the MetatagManager class, so you can get default tags for an entity, or get the complete tags with defaults for an entity. Also used it a bit in the .module file to show how some refactoring might work. I don't particularly think this NEEDS urgent refactoring in the rest of the module, but it makes a big difference for Dx to have the methods there.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | metatag-n2853515-9.patch | 4.67 KB | damienmckenna |
| #9 | metatag-n2853515-9.interdiff.txt | 2.15 KB | damienmckenna |
Comments
Comment #3
ohthehugemanatee commentedWhoops, seems I caught some recent dev branch changes in that patch. Trying again...
Comment #5
ohthehugemanatee commentedMinor fix in the .module example implementation
Comment #7
ohthehugemanatee commentedwow, didn't think through all the different cases the .module has to handle. Simplifying this patch to only provide the methods for developers in MetatagManager. Refactoring is a separate issue.
Comment #8
damienmckennaThis looks like a great idea, and might help with some other things (JSON output, etc).
I need to look over the tests to see how they could be possibly expanded to make sure this works as intended.
Comment #9
damienmckennaMinor tweaks.
Comment #11
damienmckennaRefactoring + tests work = happy Damien :)
Thanks!