Right now this is a difficult module to work with outside of the Drupal GUI use case. I found I had to duplicate a lot of code from the .module file just to get the list of tags for a node (including defaults) into an API module, for example.

Attached a patch that adds default handling into the MetatagManager class, so you can get default tags for an entity, or get the complete tags with defaults for an entity. Also used it a bit in the .module file to show how some refactoring might work. I don't particularly think this NEEDS urgent refactoring in the rest of the module, but it makes a big difference for Dx to have the methods there.

CommentFileSizeAuthor
#9 metatag-n2853515-9.patch4.67 KBDamienMcKenna
#9 metatag-n2853515-9.interdiff.txt2.15 KBDamienMcKenna
#7 2853515-metatag-add-defaults-handling-to-manager-3.patch4.55 KBohthehugemanatee
#5 2853515-metatag-add-defaults-handling-to-manager-2.patch6.58 KBohthehugemanatee
#3 2853515-metatag-add-defaults-handling-to-manager-1.patch6.52 KBohthehugemanatee
metatag-add-defaults-handling-to-manager.patch7.53 KBohthehugemanatee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ohthehugemanatee created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, metatag-add-defaults-handling-to-manager.patch, failed testing.

ohthehugemanatee’s picture

ohthehugemanatee CreditAttribution: ohthehugemanatee at Amazee Labs commented
Status: Needs work » Needs review
FileSize
2853515-metatag-add-defaults-handling-to-manager-1.patch6.52 KB

Whoops, seems I caught some recent dev branch changes in that patch. Trying again...

Status: Needs review » Needs work

The last submitted patch, 3: 2853515-metatag-add-defaults-handling-to-manager-1.patch, failed testing.

ohthehugemanatee’s picture

ohthehugemanatee CreditAttribution: ohthehugemanatee at Amazee Labs commented
Status: Needs work » Needs review
FileSize
2853515-metatag-add-defaults-handling-to-manager-2.patch6.58 KB

Minor fix in the .module example implementation

Status: Needs review » Needs work

The last submitted patch, 5: 2853515-metatag-add-defaults-handling-to-manager-2.patch, failed testing.

ohthehugemanatee’s picture

ohthehugemanatee CreditAttribution: ohthehugemanatee at Amazee Labs commented
Status: Needs work » Needs review
FileSize
2853515-metatag-add-defaults-handling-to-manager-3.patch4.55 KB

wow, didn't think through all the different cases the .module has to handle. Simplifying this patch to only provide the methods for developers in MetatagManager. Refactoring is a separate issue.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

This looks like a great idea, and might help with some other things (JSON output, etc).

I need to look over the tests to see how they could be possibly expanded to make sure this works as intended.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n2853515-9.interdiff.txt2.15 KB
metatag-n2853515-9.patch4.67 KB

Minor tweaks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Parent issue: » #2563615: Plan for Metatag 8.x-1.1 release

Refactoring + tests work = happy Damien :)

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.