Closed (outdated)
Project:
Google Programmable Search Engine
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Feb 2017 at 11:09 UTC
Updated:
4 May 2017 at 17:11 UTC
Jump to comment: Most recent
Comments
Comment #2
afinnarn commentedYeah, that module seems to only have a 6.x branch and only a few commits. Who knows if anyone actually ever used it?
Since neither of us knows what this is or is supposed to do, I think the best way forward is to mark it as deprecated in the 8.x-2.x release, whenever that gets to alpha status. If someone has used this feature, then they will probably file a ticket for a feature request.
I'm not even sure on how to test the advanced functionality other than getting a paid account. So, that's another reason to leave this part out initially.
@navneet0693what do you think?
Comment #3
afinnarn commentedComment #4
navneet0693 commented@afinnarn Commit was done by @alexmoreno, I will ask him.
Comment #5
navneet0693 commentedComment #6
alexmoreno commentedI don't remember to write this ticket, funny.
Anyway, I don't work anymore on the project I was using this, and I think it's still in D7.
If say just leave it there in case someone can pick this up at some point?
Thanks
Comment #7
navneet0693 commentedI vote of removing it from D8 :-), what are your thoughts?
Comment #8
alexmoreno commentedWell, if we don't have that functionality it would be better to have a ticket that documents that (ie, we don't have it, so we need someone to work on it). Otherwise you'll have people in the future asking, hey, what about this functionality. You'll have it anyway, but then you can point them to that ticket :-)
That's just my opinion anyway.
Comment #9
afinnarn commentedI think this ticket is proof enough that we don't know what's going on here, lol. Since the project has no documentation page, I might create one, although I don't know if this module is big enough to warrant one.
I will make a section in the description of the module about the D8 upgrade and mention this as a deprecated feature. If the readme or description page don't cover all the bases, we can add some documentation pages later, but I like the idea of putting D7 -> D8 notes in docs rather than closed issues.
What do you think?
Comment #10
afinnarn commentedI added a section in the project description. Feel free to modify that however you wish, but I think putting more info in the description section makes sense.
Comment #11
afinnarn commentedThe notice has been made on the project page so I am closing this issue.