As per https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21..., form elements attributes should be defined as arrays of strings, while the module sets the classes as '#attributes' => array('class' => 'draggableviews-parent'). This causes warning (and missing classes) in some themes, e.g. in Bootstrap.

CommentFileSizeAuthor
#3 draggableviews-class-array-2853167-3-D8.patch966 bytesalex.bukach

Comments

Alex Bukach created an issue. See original summary.

alex.bukach’s picture

alex.bukach commented
Issue summary: View changes
alex.bukach’s picture

alex.bukach commented
Assigned: alex.bukach » Unassigned
Status: Active » Needs review
StatusFileSize
new draggableviews-class-array-2853167-3-D8.patch966 bytes
karol haltenberger’s picture

karol haltenberger commented
Status: Needs review » Reviewed & tested by the community
visabhishek’s picture

visabhishek commented

Related issue : https://www.drupal.org/node/2853167 Both patches are same.

alex.bukach’s picture

alex.bukach commented

@visabhishek it is this issue you are referring to :) That is, you mention the issue as related to itself.

alex.bukach’s picture

alex.bukach commented
Status: Reviewed & tested by the community » Closed (duplicate)

See https://www.drupal.org/node/2729935. That patch was proposed a week before mine.

ressa’s picture

ressa
he/him
commented

But #2853167: Set form attribute class as array is this issue? A recurring issue with this issue :-)

alex.bukach’s picture

alex.bukach commented

Damn, I made the same mistake as @visabhishek before :D Fixed the message.