In Thunder distribution we are adding configuration testing and validation after distribution is installed. We want to ensure that configurations are always up-to-date with provided default configs and schemas by integrated modules. Here is related ticket: #2854570: Test installed configuration with configurations provided in files

Problem/Motivation

Currently adsense module doesn't have settings (configuration) schema defined and it should be provided for better validation of configuration.

Proposed resolution

Configuration schema should be created based on current default configuration and configuration form.

CommentFileSizeAuthor
#2 2853128_2.patch3.53 KBmtodor

Comments

mtodor created an issue. See original summary.

mtodor’s picture

mtodor commented
Status: Active » Needs review
StatusFileSize
new 2853128_2.patch3.53 KB

Here is patch with proposed solution:

  1. Schema file is added with appropriate configuration types
  2. Few configuration options are adjusted in default settings to match type for that type (mainly boolean types for checkbox options)
  3. Some missing configuration options are added in default settings
  4. Added cleanup of configuration on save, because some form fields are saved in base configuration and that should not happen
mtodor’s picture

mtodor commented
Issue summary: View changes
jcnventura’s picture

jcnventura
Primary language English
commented

Thanks @mtodor

I've added also the schema for the adsense_oldcode module which would also need this.

However, config is config, and the request_path plugin for core blocks saves the pages and negate properties. I'm pretty sure that if Thunder can support that from Drupal core, it should also support it from this module, so those changes weren't committed.

  • jcnventura committed 2fc019f on 8.x-1.x authored by mtodor 
    Issue #2853128 by mtodor, jcnventura: Configuration schema and...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.