Chosen not working on Dropdown widget if there are no exposed filters on view.
Since both modules are being used heavily we could add support here for it.

Providing patch for it

CommentFileSizeAuthor
#11 chosen_not_working_on-2853121-11.patch2.32 KBborisson_
#8 chosen_not_working_on-2853121-8.patch2.34 KBborisson_
#4 chosen_not_working_on_dropdown-2853121.patch694 bytesxsdx
chosen_not_working_on_dropdown.patch743 bytesxsdx

Comments

xSDx created an issue. See original summary.

xsdx’s picture

xsdx commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, chosen_not_working_on_dropdown.patch, failed testing.

xsdx’s picture

xsdx commented
StatusFileSize
new chosen_not_working_on_dropdown-2853121.patch694 bytes

Adding patch

xsdx’s picture

xsdx commented
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Not sure about this, this might lead to use having to support (and test) even more modules. I think we shouldn't do this, but leave a not in the README.txt on how to implement this from custom code?

alan-ps’s picture

alan-ps commented

I agree that we do not need this. For my mind, we should create own widget which extends DropdownWidget in this case (in custom module, not in facets).

In addition, some users prefer to use other libraries (selectize js for example). It depends from requirements.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new chosen_not_working_on-2853121-8.patch2.34 KB

Added this to the readme file, I hope this explains it fully.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review

NR

alan-ps’s picture

alan-ps commented
Status: Needs review » Reviewed & tested by the community

It looks good for me!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new chosen_not_working_on-2853121-11.patch2.32 KB

Rerolled, seeing if the patch still applies.

  • borisson_ committed b48b467 on 8.x-1.x 
    Issue #2853121 by xSDx, borisson_, alan-ps: Add documentation for chosen...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Related issues: +#2957442: Trigger JS behaviors for JS-generated Dropdown (for Chosen and others)

Here's what we should do instead!