The sensor parameter is no longer required for the Google Maps JavaScript API.
Google recommends to remove the sensor parameter from the script element:
https://developers.google.com/maps/documentation/javascript/error-messag...

CommentFileSizeAuthor
#7 gmap-remove_sensor_parameter-2852988-7.patch1.78 KBdpovshed
#7 interdiff.txt576 bytesdpovshed
#2 gmap-remove_sensor_parameter-2852988-1.patch1.25 KBdzutaro

Issue fork gmap-2852988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dzutaro created an issue. See original summary.

dzutaro’s picture

dzutaro commented
Status: Active » Needs review
StatusFileSize
new gmap-remove_sensor_parameter-2852988-1.patch1.25 KB

I made a patch.

dzutaro’s picture

dzutaro commented
dzutaro’s picture

dzutaro commented
mustanggb’s picture

mustanggb commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: gmap-remove_sensor_parameter-2852988-1.patch, failed testing.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt576 bytes
new gmap-remove_sensor_parameter-2852988-7.patch1.78 KB

Updating the tests as well.

mustanggb’s picture

mustanggb commented
Status: Needs review » Reviewed & tested by the community

Nicely done.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 7.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Needs work

doesn't apply

the_g_bomb made their first commit to this issue’s fork.

the_g_bomb opened merge request !4

the_g_bomb’s picture

the_g_bomb commented

Re-rolling against 3.0.x

the_g_bomb’s picture

the_g_bomb commented
Status: Needs work » Needs review

  • the_g_bomb committed fbf1ef8 on 3.0.x 
    Issue #2852988 Remove the sensor parameter from the script element

  • the_g_bomb committed fbf1ef8 on 7.x-2.x 
    Issue #2852988 Remove the sensor parameter from the script element
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 3.0.x-dev » 3.0.3
Status: Needs review » Fixed

Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.