As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#6 remove_file_tag-2851988-6.patch1.09 KBsneha_surve
#2 remove@file_2851988_1.patch1.09 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new remove@file_2851988_1.patch1.09 KB
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Reviewed & tested by the community

@nehakhadke Thanks, For the patch corrections!

kunalkursija’s picture

kunalkursija commented
Issue tags: +DrupalMumbaiCodeSprint16
sneha_surve’s picture

sneha_surve commented
Assigned: Unassigned » sneha_surve
sneha_surve’s picture

sneha_surve commented
Assigned: sneha_surve » Unassigned
StatusFileSize
new remove_file_tag-2851988-6.patch1.09 KB

Changing the patch name.

As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock have been removed successfully.

"The @file doc block MUST be present for all PHP files, with one exception: files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension, and whose file path is closely related to the namespace (under PSR-4 or a similar standard), SHOULD NOT have a @file documentation block."

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented

Hi @sneha_surve,

Providing inter diff file will help to review the changes.

Please refer the above document for creating the interdiff https://www.drupal.org/documentation/git/interdiff

Thanks,

sneha_surve’s picture

sneha_surve commented

Hi @Ashish

Both the patches are same. Patch given by Neha, works fine for me. I have just changed the name of the patch file as it contains special character.

kunalkursija’s picture

kunalkursija commented
Status: Reviewed & tested by the community » Fixed

Thanks for the #2 @nehakhadke.
Have Committed to new 8.x-2.x branch, Will be creating the release soon.

kunalkursija’s picture

kunalkursija commented

Thank you for the contribution guys.
I have added a new release that fixes this issue.
Here is 8.x-2.0 release: https://www.drupal.org/project/age_calculator/releases/8.x-2.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.