Spun out of #1559310: 404 pages should be language aware - the redirect_404 module has a dependency on the language module. I don't want to have to enable the language module, on a non-multilingual site, just in order to gain access to this functionality. It seems that there is no need for such a dependency for the module, and in initial tests after disabling it, everything seems to be working fine. Let's see if this passes the tests.

CommentFileSizeAuthor
#5 2851810-5-remove_redirect_404_language_dependency.patch884 bytesstella
#2 2851810-1-remove_redirect_404_language_dependency.patch308 bytesstella

Comments

stella created an issue. See original summary.

stella’s picture

stella commented
StatusFileSize
new 2851810-1-remove_redirect_404_language_dependency.patch308 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2851810-1-remove_redirect_404_language_dependency.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The HEAD test fail is fixed now.

Can you also update the dependency in \Drupal\redirect_404\Tests\Fix404RedirectUILanguageTest? As far as I see, it only needs to depend on language, not content_translation.

stella’s picture

stella commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2851810-5-remove_redirect_404_language_dependency.patch884 bytes

Updated patch which adds in dependency on language module in the tests. I've also removed the 'content_translation' dependency at your suggestion.

  • Berdir committed b3e2c39 on 8.x-1.x authored by stella 
    Issue #2851810 by stella: redirect_404 module has a dependency on...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.