I have problem when I use "Webform Google Exporter" module for export to Google drive. For exporter In download method we have drupal_goto to google authorization page and we will never go back into webform_results_download function for save the last exported sid. I think will be great to get export information array in download method.

CommentFileSizeAuthor
#4 export_information_array-2851753-2.patch688 bytesanton4uk
#2 export_information_array-2851753-1.patch824 bytesanton4uk

Comments

Anton4yk created an issue. See original summary.

anton4uk’s picture

anton4uk commented
Status: Active » Needs review
StatusFileSize
new export_information_array-2851753-1.patch824 bytes

Status: Needs review » Needs work

The last submitted patch, 2: export_information_array-2851753-1.patch, failed testing.

anton4uk’s picture

anton4uk commented
StatusFileSize
new export_information_array-2851753-2.patch688 bytes
anton4uk’s picture

anton4uk commented
Status: Needs work » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Do you need this change to make something work in Webform Google Exporter? Is there an issue for that?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Category: Task » Feature request
anton4uk’s picture

anton4uk commented

Hello @Liam Morland,

Yes, these changes need for fix bug in Webform Google Exporter. Issue was created with patch.

Thank you!

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Postponed (maintainer needs more info)

Please post a link to the issue.

anton4uk’s picture

anton4uk commented

Sure,

https://www.drupal.org/node/2461859

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Postponed (maintainer needs more info) » Needs review

Thanks. When linking to an issue, please do it like [#nnnnnn]. That would make a nice labelled link like this: #2461859: Only new submissions since your last download

  • Liam Morland committed 9f28bec on 7.x-4.x authored by Anton4yk 
    Issue #2851753 by Anton4yk: API change: Provide $export_info to exporter...
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Export information array into download method. » API change: Provide $export_info to exporter::download()
Assigned: Unassigned » liam morland
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.