"Only new submissions since your last download" on the download page works incorrectly for Send to Google Drive (Google Docs).

CommentFileSizeAuthor
#5 webform_google_export_last_download-2461859-5.patch992 bytesanton4uk
#4 webform_google_export_last_download-2461859-4.patch1.16 KBanton4uk
#2 webform_google_export_last_download-2461859-1.patch1.24 KBanton4uk
#1 webform_google_export_last_download-2461859-1.patch5.86 KBanton4uk

Comments

anton4uk’s picture

anton4uk commented
Status: Active » Needs review
StatusFileSize
new webform_google_export_last_download-2461859-1.patch5.86 KB
anton4uk’s picture

anton4uk commented
StatusFileSize
new webform_google_export_last_download-2461859-1.patch1.24 KB
quicksketch’s picture

quicksketch
he/him
commented

Thanks @Anton4yk! Couldn't this same thing be accomplished by calling webform_results_export_success($node, $export_info), rather than essentially duplicating the code in that function?

anton4uk’s picture

anton4uk commented
StatusFileSize
new webform_google_export_last_download-2461859-4.patch1.16 KB

Thanks @quicksketch, not need duplicating code. I did this patch and new related one for webform module https://www.drupal.org/node/2851753

anton4uk’s picture

anton4uk commented
StatusFileSize
new webform_google_export_last_download-2461859-5.patch992 bytes
mkdok’s picture

mkdok commented
Status: Needs review » Reviewed & tested by the community

Hi all,

This patch work for me. Mark that patch as RTBC.

Thanks.