Closed (outdated)
Project:
Feeds
Version:
7.x-2.0-beta3
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2017 at 22:55 UTC
Updated:
26 Nov 2025 at 14:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gturnbull commentedComment #3
gturnbull commentedComment #4
gturnbull commentedComment #5
megachriz@gturnbull
It seems that your patch contains some environment specific configuration:
It would be better if you export your view from within a clean install.
Still have to test the patch, though. I had only a few minutes for Feeds now.
Comment #6
gturnbull commentedHi MegaChriz,
I removed the environment specific configuration settings, re-exported my view, and created a new patch.
Thank you for taking the time to review this new feature.
Thank you,
Gordon
Comment #7
gturnbull commentedComment #8
megachrizI get the following error message on the feeds log page after applying the patch:
See also the image:

I checked if I could fix the error by editing the view, but then I could only add a text field as exposed filter for the importer. A field where you can select the importer would indeed be nicer. I think that you have an extra module installed so that the exposed filter became a select field? Anyway, to fix this for everyone we probably need a Views filter plugin specific for the importer ID.
Comment #9
gturnbull commentedHi MegaChriz,
I figured out the problem! The exposed filter I added for the Importer ID field uses a select box feature provided by the views_selective_filters module.
I updated the feeds.info file to include a dependency for the views_selective_filters module, then generated an updated version of my patch.
If you have a moment, please test my latest patch and let me know what you think.
Your feedback is greatly appreciated.
Thanks,
Gordon
Comment #10
gturnbull commentedComment #12
megachrizHm, adding an extra dependency for Feeds for such a small feature doesn't look like a good idea to me. People will complain that they would need to install an extra module for a feature that they don't use. See for example #1355994: Remove Job Scheduler dependency.
The way to fix this with the least impact is to write a specific Views filter handler for the Importer ID field.
Comment #13
gturnbull commentedHi MegaChriz,
Thanks again for your feedback. I will create a separate views handler to power the select box filter implemented for the Importer ID field.
In the meantime, I noticed an error in my last patch. The machine name of the module referenced by the dependency was not correct. Updated patch attached.
Thank you,
Gordon
Comment #14
bluegeek9 commentedUnfortunately, Drupal 7 is End of Life and no longer supported. We strongly encourage you to upgrade to a supported version of Drupal.