Closed (duplicate)
Project:
Drupal core
Version:
8.4.x-dev
Component:
user interface text
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2017 at 06:09 UTC
Updated:
27 Feb 2017 at 07:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joachim commentedRemoving the technical term 'boolean' is a good idea, but also, I think that checkboxes can seem a bit ambiguous with a label that's an action rather than a state.
Comment #3
kattekrab commentedI looked back at Drupal7 and just like promoted and sticky... it was just the word, and on or off, so I reckon that would be better here too.
eg.
☑ Published.
Comment #4
kattekrab commentedHere's a patch.
Comment #5
kattekrab commentedDear testbot, please test my patch.
Comment #6
larowlansuggestion 'Whether or not the item is published'?
my 2c
also, yellow bikeshed
But yeah, anything is better than what we have now
Comment #7
kattekrab commentedYellow is my favourite colour @larowlan :-)
Comment #8
dinesh18 commentedHello,
I don't think so it is required to change the description. It seems to sound understandable with the word boolean.
Comment #9
joachim commentedThe point is to get rid of the term 'boolean', which many end-users won't know.
The label and description set here are what ends up in the form for the entity.
Comment #10
dinesh18 commentedWe can use #4 patch if we need to get rid of the word "boolean".
It seems to be short and meaningful.
Comment #11
kattekrab commentedSetting this back to needs review.
Comment #12
kattekrab commentedI've changed the title of the issue to make it clearer where this ended up.
Not changing the description, removing it entirely, as was done for "Promoted" and "Sticky at top of lists".
Comment #13
kattekrab commentedComment #14
kattekrab commentedComment #15
kattekrab commentedSo... what else does this need?
Anyone else willing to review and either give feedback, or RTBC?
Comment #16
gábor hojtsyLooks good. What would this do to existing sites? Is the metadata updated there automatically?
Comment #17
kattekrab commentedGood question.
I have no idea. And no idea how we would even check that.
Comment #18
berdirThis is fine on existing sites apart from being a string change, obviously. As commented in #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button, I would recommend to merge this into that, as we already make pat of the change generically and the other half just for node.
Comment #19
kattekrab commentedClosing this as a dupe of #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button
Comment #20
kattekrab commented