Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff_16-18.txt | 22.69 KB | mondrake |
#18 | 2848820-18.patch | 23.04 KB | mondrake |
Comments
Comment #2
vidhatanand CreditAttribution: vidhatanand at OpenSense Labs commentedComment #3
vidhatanand CreditAttribution: vidhatanand at OpenSense Labs commentedComment #4
JayKandariOnly 1 instance of "db_transaction()" found. #2 Looks good.
Thanks.
Comment #5
cilefen CreditAttribution: cilefen commentedRead the issue summary carefully about test usage replacements.
Comment #6
xjmComment #7
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedComment #9
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedComment #10
Sharique CreditAttribution: Sharique as a volunteer commentedDocumentation will be updated in separate ticket.
Documentation will be updated in separate ticket.
Not sure, this change is required or not in the context of ticket.
Comment #11
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commented@Sharique
point 1 and 2: Done
Point 3: I think we need to inject the dependency.
Comment #14
volegerNot correct
create()
method implementation. Database service should pass through the third argument. Anyway, I guess it is redundant code. Database service injecting already defined incore.services.yml
Comment #15
andypostgrep through core shows that *this->connection* is mostly used against *this->database*
Comment #16
andypostRerolled, added triggering deprecated error & test
Also converted
core/tests/Drupal/KernelTests/Core/Database/TransactionTest.php
I'm sure changes are in scope cos test for
inTransaction()
should be made from the same connection asstartTransaction()
requestedLinked to #2947775: Move setting default target out of db_merge() and other deprecated db_* functions cos setting defaults needs solved somehow
There's is only 2 mentions in docs but that's separate issue
Transactions are per connection but database mostly used in backend specific implementation
Comment #18
mondrakeRerolled, added reference to CR in the deprecation msg, adjusted test to benefit from the $connection property being available from DatabaseTestBase, changed in test the returns to markTestSkipped where necessary.
If it turns back green this should be close to ready now.
Comment #20
volegerLooks good.
Comment #23
catchCommitted/pushed to 8.7.x, thanks!