When installing I got this error:
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service [error]
"default_content.manager" has a dependency on a non-existent service "plugin.manager.rest". in
..../vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:58Looks like it was because there was no dependency to the rest module defined in the info.yml file. If I add a dependency to the rest module installation works fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | dependency_on_rest-2848425-12.patch | 260 bytes | andypost |
| #6 | dependency_on_rest-2848425-6.patch | 240 bytes | kalpaitch |
Comments
Comment #2
Yaron Tal commentedComment #3
andypostModule depends on hal that depends on rest so all dependencies are fine
I found no way to enable default content without enabling hal, rest & serialization
Comment #4
kalpaitch commentedI agree Andy, however it is weird that this issue is appearing. For a further reference the same is happening with the test that failed on #2698425: Do not reimport existing entities - https://www.drupal.org/pift-ci-job/586793
Comment #5
kalpaitch commentedAlso, am I missing something. I thought it was as you said Andy too... because I can only see Rest and HAL depend on Serialization but not on each other.
http://cgit.drupalcode.org/drupal/tree/core/modules/hal/hal.info.yml?h=8...
http://cgit.drupalcode.org/drupal/tree/core/modules/rest/rest.info.yml?h...
Comment #6
kalpaitch commentedApologies for the comment flourishes, could to get this one in and pass other tests.
Comment #8
andypostbtw 8.3.x core changed dependencies #2758897: Move rest module's "link manager" services to serialization module
and now looks no need to depend on rest
Comment #9
larowlanWhat @andypost said
Comment #10
andypostI checked tests, and looks now we need to remove rest module from tests
tests/src/Functional/DefaultContentTest.php:24and usage of
rest.link_managerin\Drupal\Tests\default_content\Kernel\DefaultContentManagerIntegrationTestright now I have no idea how to make it right (backward compatible)
Comment #11
andypostClosed as duplicate #2849146: Drupal 8.3-alpha1: missing dependency
Comment #12
andypostI think better to define dependencies this way
Comment #14
andypostLooks we need to split versions for core 8.2 and later to get rig of rest dependency in tests
Comment #15
berdir#6 looks correct to me and is compatible with 8.2 - 8.4, we can remove the deprecated code later when 8.3 is stable (or any time between then and 9.x)
The test dependencies in DefaultContentTest are indeed not really necessary, it would make sese to only depend on default_content to make sure that we have our own dependencies right. But that's not a new issue and doesn't need to be fixed as part of this.
Comment #17
andypostCommited and filed #2850977: Branch 8.x-2.x to get rid of rest module dependency for 8.3.x core