It's impossible to override bootstrap variables and compile it again in the subtheme as the basetheme already have a compiled static css file which will make it very hard to update and override bootstrap variables in a proper way.

check varbase 7 theme : http://cgit.drupalcode.org/varbase/tree/themes/vartheme?h=7.x-3.x
I think that the base theme should have only theme templates and some hooks instead of having a compiled css file.

Comments

mqanneh created an issue. See original summary.

mqanneh’s picture

Title: Conflicts between subtheme and base theme styles. » Conflicts between subtheme and base theme stylesheets.
Assigned: mqanneh » Unassigned
Status: Active » Needs review
StatusFileSize
new284.31 KB
rajab natshah’s picture

We will have number of sessions:

  • [Session] Varbase initialization for new projects.
  • [Session] Create new vartheme sub-theme, and styling in Vartheme sub-theme.
  • [Session] Introduction to SMACSS.
  • [Session] Right to Left (RTL) in Vartheme and Vartheme Subtheme.
  • [Documentation] Writing the Varbase 8.4.x Developer Guide.

Please do not wast time before that.

You do have number of options.

1. Exclusive and exclude some of the base theme libraries.
2. Double load, which I'm trying to avoid.
3. Load on vartheme base theme only.
4. Only load in sub theme.

Which one do you think is better? or if you do have other options

You could exclude in Drupal 8.. It's not like Drupal 7

Haven’t you read my last comment on #2843640: Missing bootstrap libraries include in theme info file

rajab natshah’s picture

Category: Bug report » Support request
mqanneh’s picture

Assigned: Unassigned » mohammed j. razem
Category: Support request » Bug report
StatusFileSize
new1.19 KB

Check updated patch file.

rajab natshah’s picture

  • RajabNatshah committed 695b5bd on 8.x-4.x authored by mqanneh
    Issue #2843810 by mqanneh, RajabNatshah: Conflicts between subtheme and...
rajab natshah’s picture

Thank you.

Committed 2843810-5.patch with a bit of change for (RTL) right to left websites.

# OPTIONALLY: You can choose to remove Vartheme base theme stylesheets and/or
# Javascript files.
# Uncomment these lines to exclude css and js files from vartheme.
# libraries-override:
#   vartheme/global-styling:
#     css:
#       theme:
#         css/style.css: false
#   vartheme/global-scripts:
#     js:
#       js/script.js: false
#   # Uncomment the following lines for right to left.
#   # vartheme/global-styling-rtl:
#   #   css:
#   #     theme:
#   #       css/style-rtl.css: false

Rewarded :)

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Title: Conflicts between subtheme and base theme stylesheets. » Updated [Varbase 8.4.x] profile: Updated [VARTHEME_SUBTHEME] theme: Fixed Conflicts between subtheme and base theme stylesheets.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.