CommentFileSizeAuthor
#6 google_AdSense_integration-2843799-6.patch1.15 KBznak
#2 Google_Adsense_2843799_1.patch47.61 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new Google_Adsense_2843799_1.patch47.61 KB

  • jcnventura committed 09b39e7 on 8.x-1.x 
    Issue #2843799: use ->t() instead of t(), in objects
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Re-did it from scratch, as you can't do this blind replacement inside static functions.

  • jcnventura committed 62a2c4a on 8.x-1.x 
    Issue #2843799: t() function is not inherited in AdsenseAd plugins
znak’s picture

znak commented
Status: Fixed » Needs review
StatusFileSize
new google_AdSense_integration-2843799-6.patch1.15 KB

Additions to the previous patch. Please, check up.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

@Znak, as the comment to the patch in #5 says: "t() function is not inherited in AdsenseAd plugins". This means that it makes no sense to add $this->t() to those Plugins. If it works, it's because of magic, and not proper OOP.

However, it seems that it's sufficient to add " use StringTranslationTrait;" to the AdsenseAdBase class, so I'll do that next time.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.