Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#6 | google_AdSense_integration-2843799-6.patch | 1.15 KB | Znak |
#2 | Google_Adsense_2843799_1.patch | 47.61 KB | nehakhadke |
Comments
Comment #2
nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commentedComment #4
jcnventura CreditAttribution: jcnventura at Wunder commentedRe-did it from scratch, as you can't do this blind replacement inside static functions.
Comment #6
Znak CreditAttribution: Znak commentedAdditions to the previous patch. Please, check up.
Comment #7
jcnventura CreditAttribution: jcnventura at Wunder commented@Znak, as the comment to the patch in #5 says: "t() function is not inherited in AdsenseAd plugins". This means that it makes no sense to add $this->t() to those Plugins. If it works, it's because of magic, and not proper OOP.
However, it seems that it's sufficient to add " use StringTranslationTrait;" to the AdsenseAdBase class, so I'll do that next time.
Comment #9
jcnventura CreditAttribution: jcnventura at Wunder commented