Follow-up to #2841496: Add additional PHPUnit tests to Helper classes

Problem/Motivation

WebformBreadcrumbBuilder has no test coverage.

Proposed resolution

Refactor and add tests to WebformBreadcrumbBuilder.

Remaining tasks

  • Fix dependency injection
  • ::testApplies()
  • ::testBuild()

@see

  • \Drupal\forum\Breadcrumb\ForumBreadcrumbBuilderBase
  • \Drupal\Tests\forum\Unit\Breadcrumb\ForumBreadcrumbBuilderBaseTest
  • \Drupal\Tests\forum\Unit\Breadcrumb\ForumNodeBreadcrumbBuilderTest
CommentFileSizeAuthor
#9 refactor_and_add_tests-2841792-9.patch50.28 KBjrockowitz
#3 refactor_and_add_tests-2841792-2.patch23.49 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

  • 3b9909f committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new refactor_and_add_tests-2841792-2.patch23.49 KB

  • 5d8a022 committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder/

  • d1ddcd0 committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder. Add...

  • 8550338 committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder. Add...

  • f313fcb committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder....

  • 186fae4 committed on 2841792-refactor-breadcrumb-builder 
    Issue #2841792: Refactor and add tests to WebformBreadcrumbBuilder.
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new refactor_and_add_tests-2841792-9.patch50.28 KB

Status: Needs review » Needs work

The last submitted patch, 9: refactor_and_add_tests-2841792-9.patch, failed testing.

  • jrockowitz authored 717cdbc on 8.x-5.x 
    Issue #2841792 by jrockowitz: Refactor and add tests to...
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.