In preparation for a new stable version (7.x-2.6).

233 | WARNING | Unused variable $rows_max.
234 | WARNING | Unused variable $cols_max.
235 | WARNING | Unused variable $count_rows.
236 | WARNING | Unused variable $count_cols.
989 | WARNING | Unused variable $row_id.
1198 | WARNING | Unused variable $row_num.
1205 | WARNING | Unused variable $k2.

CommentFileSizeAuthor
#4 restored_false_unused_variable-2841586-3.patch527 byteslolandese
#2 remove_unused_variables-2841586-2.patch1.56 KBlolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Fixed
StatusFileSize
new remove_unused_variables-2841586-2.patch1.56 KB

  • lolandese committed 8104259 on 7.x-2.x 
    Issue #2841586 by lolandese: Fix some Code Sniffer Best practice...
lolandese’s picture

lolandese commented
StatusFileSize
new restored_false_unused_variable-2841586-3.patch527 bytes

We have to restore one variable that is needed to suppress the weight column. After e.g. uploading a CSV we saw both the dragging handles in the first column (in Edit mode) and the weights in the last column. This was retained on Save resulting in seeing the weights also in View mode.

Attached patch fixes the issue.

  • lolandese committed f02bc32 on 7.x-2.x 
    Issue #2841586 by lolandese: Restore a variable that was indicated as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.