The modules adds a "settings" key to the $variables array in site_settings.module:

/**
 * Implements hook_preprocess().
 */
function site_settings_preprocess(&$variables) {
  $site_settings = \Drupal::service('site_settings.loader');
  $variables['settings'] = $site_settings->loadAll();
}

I noticed some strange markup on my site and figured out that $variables['settings'] is also used by the popular Display Suite module (https://www.drupal.org/project/ds).

I suggest that this module use $variables['site_settings'] instead.

I will submit a patch as soon as an issue number is assigned.

CommentFileSizeAuthor
#2 site_settings-rename-variables-key-2841488-1.patch475 bytesesomething

Comments

esomething created an issue. See original summary.

esomething’s picture

esomething commented
StatusFileSize
new site_settings-rename-variables-key-2841488-1.patch475 bytes
scott_euser’s picture

scott_euser commented
Assigned: Unassigned » scott_euser

Hi esomething,

Thanks for finding the conflict with display suite and the patch. Please use your patch for now, I will try to make a non-breaking upgrade path before releasing.

I am thinking:

  1. Give admin control over key
  2. New installs set default key site_settings
  3. Upgrades leave key as is
  4. Dismiss-able warning about conflict on manage site settings page if key is set to settings

Thanks,
Scott

esomething’s picture

esomething commented

Thanks for the quick response, Scott. That sounds like a good plan to me.

  • scott_euser committed 0b86378 on 8.x-1.x 
    Issue #2841488 by esomething, scott_euser: Fix conflict with Display...
scott_euser’s picture

scott_euser commented
Status: Active » Fixed

Hi esomething,

This is now fixed on 8.x-1.3 release. Again, thanks for finding the issue!

  • New installs will default to site_settings as the template key.
  • Previous installs will see a warning recommending them to change the template can which can be done via admin > config > site settings configuration.

Scott

scott_euser’s picture

scott_euser commented
Status: Fixed » Closed (fixed)