Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#14 | jsonapi_remove_plugin-2841056-14.patch | 26.07 KB | Wim Leers |
|
Comments
Comment #2
Wim LeersThis is blocked on #2841050: Make ResourceConfig an actual value object: immutable, with no services injected, which is blocked on #2841048: Remove ResourceConfig::getGlobalConfig(), and stop injecting the config factory service in ResourceConfig value objects.
Comment #3
Wim LeersComment #4
Wim LeersAlso, this is a net reduction:
8 files changed, 48 insertions, 310 deletions
:)Comment #5
Wim LeersRemove the plugin manager.
Remove the sole plugin's deriver.
Remove the plugin interface.
Switch from the plugin manager to the resource manager.
Turns out this is a simplification we can make here.
This converts from using the plugin manager to the resource manager. This is basically the key change.
This is also basically the only thing we need to change when we drop the use of plugins.
Which just goes to show how little we used plugins :)
Comment #6
Wim LeersHah, apparently I forgot to remote the annotation.
The net reduction is now even better:
9 files changed, 48 insertions, 364 deletions
:)Comment #7
e0ipsoComment #8
Wim Leers#2841050: Make ResourceConfig an actual value object: immutable, with no services injected landed, this is now unblocked!
Comment #10
Wim LeersBecause #2841050: Make ResourceConfig an actual value object: immutable, with no services injected was modified since creating #6, the patch in #6 no longer applies. Here's a rebased patch.
Comment #11
Wim LeersDammit, cross-posted.
Comment #13
Wim LeersAh, of course, I rebased the patch so it applies, but the changes in #2841050-15: Make ResourceConfig an actual value object: immutable, with no services injected require another change to happen here too. Patch coming…
Comment #14
Wim LeersAnd done.
Comment #15
Wim LeersThe rationale explanation in #5 still applies. #10 and #14 were only necessary to adjust for the modifications to the patch in #2841050: Make ResourceConfig an actual value object: immutable, with no services injected made after #2+#6 were created.
Comment #16
Wim LeersThis blocks #2841056: Remove use of plugins.
Comment #17
Wim LeersEh, #2841287: Remove ResourceManager::hasBundle(), ResourceManager::getEntityTypeManager(), ResourceConfig::getPath(), and rename ResourceConfig::getBundleId() of course.
Comment #18
e0ipsoI checked, and this change does not conflict with the \Drupal\jsonapi\Routing\RouteEnhancer. So, :+1:
I'm merging this.
Comment #20
e0ipsoComment #21
Wim LeersYay!