I have a simple webform with a couple of fields. I have a date/time field with both date and time. Everything works great, except in Firefox where the time and date inputs are not supported.

The date fallback works very good. But the time fallback crashes Firefox. I notice that $input.data('webformTimeFormat') is not set, but I don't know if that's the reason.

Could be related to https://www.drupal.org/node/2834027

CommentFileSizeAuthor
#3 timepicker_js_fallback-2840391-3.patch1.09 KBjrockowitz

Comments

andeersg created an issue. See original summary.

andeersg’s picture

andeersg commented

Forgot to mention, I encountered this on macOS, with Firefox 50.1 and Firefox ESR.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new timepicker_js_fallback-2840391-3.patch1.09 KB

Definitely related to #2834027: Jquery Timepicker script error for Mozilla Firefox..

The datatime element's step attribute is defaulting to 1 second increments while the timepicker fallback is looking for seconds.

  • jrockowitz committed 32f89f2 on 8.x-5.x 
    Issue #2840391 by jrockowitz: Timepicker.js fallback crashes Firefox
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
andeersg’s picture

andeersg commented

Wow, that was quick. It works now :)

But it does not seem like it respects the time and date format from webform settings.

jrockowitz’s picture

jrockowitz commented

The timepicker definitely has limitations especially when used as the fallback to a datetime element.

You should follow #1838234: Add jQuery Timepicker for the Time element of the datetime field and see how core decides to integrate the timepicker.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.