Hi!

Just a few coding standards improvements.

I hope to help.

Thanks.

CommentFileSizeAuthor
#5 coding_standards-2840389-5.patch2.63 KBcebasqueira
#2 coding_standards-2840389-2.patch480 bytesgmaltoni
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gmaltoni created an issue. See original summary.

gmaltoni’s picture

gmaltoni CreditAttribution: gmaltoni at CI&T commented
FileSize
coding_standards-2840389-2.patch480 bytes

Patch with fixes.

gg24’s picture

gg24 CreditAttribution: gg24 as a volunteer and at QED42 commented
Category: Bug report » Support request

Changed Category as PHP is a loosely typed language.

gmaltoni’s picture

gmaltoni CreditAttribution: gmaltoni at CI&T commented
Assigned: gmaltoni » Unassigned
cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
FileSize
coding_standards-2840389-5.patch2.63 KB

More Coding Standards fixes

gmaltoni’s picture

gmaltoni CreditAttribution: gmaltoni at CI&T commented
Status: Needs review » Reviewed & tested by the community

@cebasqueira, I applied your patch and it worked cleanly.

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Category: Support request » Task 
  1. +++ b/sharethis.module
@@ -184,7 +186,7 @@ function sharethis_theme($existing, $type, $theme, $path) {
+function sharethis_get_light_options(array $data_options) {

    Type hinting is good :) 

  2. +++ b/sharethis.module
@@ -367,7 +369,7 @@ function theme_sharethis($variables) {
-        '#value' => '', //It's an empty span tag.

    I see no reason of removing a comment.

Updating category, I am not changing the status as I will leave with maintainers to decide.

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.