Once 8.2 reaches EOL, we should update our Core dependency on 8.3. This issue documents this, and collects associated clean-up we want to do at this point.

Clean-up tasks:

  • Simplify \Drupal\Tests\search_api\Functional\ViewsTest::installDrupal().
  • \Drupal\search_api\Plugin\views\field\SearchApiEntityField should extend \Drupal\views\Plugin\views\field\EntityField.
CommentFileSizeAuthor
#3 2840274-3--core_dependency_8_3.patch22.53 KBdrunken monkey
#3 2840274-3--core_dependency_8_3--interdiff.txt12.26 KBdrunken monkey
#2 2840274-2--core_dependency_8_3.patch9.97 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2840274-2--core_dependency_8_3.patch9.97 KB

This would implement the tasks collected so far.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Postponed » Needs review
StatusFileSize
new 2840274-3--core_dependency_8_3--interdiff.txt12.26 KB
new 2840274-3--core_dependency_8_3.patch22.53 KB

A lot of other sub-tasks got added since via @todo comments, but this should fix all of them. And now that we have 1.1 out, I think we can safely proceed with this.

Patch attached, please test/review!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

From just a look at the code, this looks solid. Haven't tested yet.

idebr’s picture

idebr commented

I suppose #2819641: Replace REQUEST_TIME with service calls can be closed as a duplicate, since this issue implements \Drupal\Component\Datetime\TimeInterface?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed a531ffd on 8.x-1.x 
    Issue #2840274 by drunken monkey, borisson_: Updated the Core dependency...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

@ idebr: Yes, that's a duplicate.

@ Joris: Thanks a lot for testing and reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.