The config of the facet summary is currently not working as it should. We know this because we have to disable strict config checking in the tests. This means that the config is probably not completely deployable.

In this issue, we should reenable the strict config checking and fix the failures that are being shown because of that.

CommentFileSizeAuthor
#7 fix_configuration-2840173-7.patch1.78 KBborisson_
#7 interdiff-2840173.txt584 bytesborisson_
#5 fix_configuration-2840173-5.patch1.78 KBborisson_

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Component: Code » Facet summary

Changing component.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: Facet summary - enable strict config » Fix configuration schema for summaries

Enable the strict config checking should help us figure out what's wrong with the current schema.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +beta blocker

Fixing the config schema could lead to an API break, so we should do this before we tag the first beta.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new fix_configuration-2840173-5.patch1.78 KB
idebr’s picture

idebr commented
Status: Needs review » Needs work 
+++ b/modules/facets_summary/config/schema/facets_summary.processor.schema.yml
@@ -14,3 +14,11 @@ plugin.plugin_configuration.facets_summary_processor.show_text_when_empty:
+    link_text:
+      type: string
+      label: 'The text to show for the reset link.'

For the link_text to be translatable through Config translation, this should be type: label. For reference, see https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

This would also solve #2877322: Facet summary, Reset facets link text not Translatable

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2840173.txt584 bytes
new fix_configuration-2840173-7.patch1.78 KB

@idebr, you're absolutely right! Thanks

  • borisson_ committed c8e1d68 on 8.x-1.x 
    Issue #2840173 by borisson_, idebr: Fix configuration schema for...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.