Comments

vanyamtv created an issue. See original summary.

jrockowitz’s picture

Status: Active » Postponed (maintainer needs more info)

I can't duplicate the issue using the 'Test: Handler: Email advanced' (/webform/form/test-handler-email-advanced)

Can you please document the steps needed to reproduce this issue?

vanyamtv’s picture

  • Open the submissions list page: /admin/structure/webform/manage/flex/results/submissions
  • Under operations, click "Resend" on any submission
  • Then just click "Resend message". At least in Gmail you'll receive encoded html.
jrockowitz’s picture

Can you upload your example form so that I can duplicate the issue?

Are you able to duplicate the problem using 'Test: Handler: Email advanced'?

You will need to add $settings['extension_discovery_scan_tests'] = TRUE; to settings.php and enable to the webform_test.module to access this form.

zhouhana’s picture

StatusFileSize
new165.6 KB

I just ran into the same issue. When I try to resend the e-mail, the letter "ö" is suddenly " & o u m l ; " and Drupal complains that "Entity 'ouml' not defined". See attached image.

jrockowitz’s picture

I need to be able to duplicate the issue so that I can fix it.

@zhouhana Can you please create a working example with hardcoded values that duplicates the problem, export it, and upload it here?

zhouhana’s picture

StatusFileSize
new174.94 KB

I'm not sure how to do that, but all you need to do is

1. Install a fresh copy of Drupal 8 with Webform enabled
2. Edit the body message of one of the e-mail handlers of the example Contact form to read, for example, "ö", instead of "[webform_submission:values:message:value]".
3. Use the test function to send it.
4. Go to Results and try to resend it.

See attached image of the result I get after completing these steps.

To make the patch fool proof, I guess it's a good idea to test with several HTML entities: https://dev.w3.org/html5/html-author/charref

jrockowitz’s picture

Status: Postponed (maintainer needs more info) » Needs work

@zhouhana That helps a lot. I was not hard coding the special character in the actual email body. I was entering it via the message body, which works fine.

  • jrockowitz committed 687aad2 on 2839897-resend-html-tags
    Issue #2839897 by zhouhana, jrockowitz, vanyamtv: Resend submission's...
jrockowitz’s picture

Status: Needs work » Needs review
StatusFileSize
new81.77 KB
new160.63 KB
new166.28 KB
new1.39 KB

The sent email looks fine.

One immediate issue is the 'Resend' form is displaying the HTML source, which might be causing some confusion.

The best solution is to just enable the HTML editor on the 'Resend' form, which creates a much cleaner and predictable UX.

If all the tests pass, I commit the attached patch and wait for more feedback.

  • jrockowitz committed 05c80b1 on 8.x-5.x
    Issue #2839897 by jrockowitz, zhouhana, vanyamtv: Resend submission's...
jrockowitz’s picture

Status: Needs review » Fixed

I committed the patch and I am going to mark this as fixed.

Please review using the latest dev release and reopen this ticket if the issue still persists.

zhouhana’s picture

Works great here as well. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.