Fix testfailure in db defaults tests on travis [#2839445]

There's a testfailure on https://travis-ci.org/mkalkbrenner/search_api_integration_tests/builds/1...

TypeError: Argument 2 passed to Drupal\Tests\BrowserTestBase::drupalPostForm() must be of the type array, null given, called in /home/travis/build/mkalkbrenner/drupal/modules/search_api/modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php on line 68

Comment	File	Size	Author
#4	2839445-4--test_test_one_two.patch	415 bytes	drunken monkey
#4	8.x-1.x: PHP 7 & MySQL 5.5, D8.3 330 pass PHP 7 & MySQL 5.5, D8.2 330 pass
#2	fix-drupalpostform-call.patch	792 bytes	borisson_
#2	8.x-1.x: PHP 7 & MySQL 5.5, D8.3 330 pass PHP 7 & MySQL 5.5, D8.2 330 pass
	fix-drupalpostform-call.patch	792 bytes	borisson_

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 December 2016 at 09:43

borisson_ created an issue. See original summary.

Comment #2

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ as a volunteer and commented 27 December 2016 at 09:43

File	Size
fix-drupalpostform-call.patch	792 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.3 330 pass PHP 7 & MySQL 5.5, D8.2 330 pass

1 file was hidden/shown/deleted

File	Size
fix-drupalpostform-call.patch	792 bytes

Comment #3

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ as a volunteer and commented 27 December 2016 at 09:44

Status:

Active

» Needs review

go testbot, go.

Comment #4

drunken monkey

he/him

German

Vienna, Austria

CreditAttribution: drunken monkey as a volunteer commented 27 December 2016 at 09:48

File	Size
2839445-4--test_test_one_two.patch	415 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.3 330 pass PHP 7 & MySQL 5.5, D8.2 330 pass

Checking whether/where tests currently break.

Comment #5

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ as a volunteer and commented 27 December 2016 at 10:21

Looks like the tests don't fail on drupalci, however I don't see any reason not to commit this either.

Comment #6

27 December 2016 at 10:35

drunken monkey committed c45aa56 on 8.x-1.x authored by borisson_

Issue #2839445 by borisson_: Fixed test failure in for some Core...

Comment #7

drunken monkey

he/him

German

Vienna, Austria

CreditAttribution: drunken monkey as a volunteer commented 27 December 2016 at 10:35

Component:	General code	» Tests
Status:	Needs review	» Fixed

Yes, of course. Just interesting – but seems it's merely #2797947: Allow NULL as second parameter in BTB->drupalPostForm() that allowed NULL values, so it depends on the Core version.
Committed – thanks a lot for the patch!