Would be nice to have libraries support, if you don't have the lib in docroot/libraries.

For examples distributions have their libs in docroot/profile/thunder/libraries

CommentFileSizeAuthor
#4 2837982_3.patch2.81 KBcriz
#2 2837982_2.patch1.63 KBchr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
FileSize
2837982_2.patch1.63 KB

Here we go

  • criz committed 674bff1 on 8.x-1.x authored by chr.fritsch 
    Issue #2837982 by chr.fritsch: Load right library version for shariff...
criz’s picture

criz
he/him
Location Vienna/Austria
CreditAttribution: criz at acolono GmbH commented
FileSize
2837982_3.patch2.81 KB

Thanks, I committed the missing library variant when loaded as a field.

Here is an updated patch for the libraries support (the naked variant was implementing css instead of js and hook_requirements has been updated).
However, as the current libraries implementation is deprecated and will be removed before a stable Drupal 8 release I'm not sure if we should commit this? Any thoughts?

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented

Yes, thats true, but IMHO i guess currently its the only way to do it. In libraries there is actual no development, so god knows when this will change. Other modules like dropzone or slick are doing it in the same way. So i think for know it's fine.

  • criz committed 1a3c7ae on 8.x-1.x 
    Issue #2837982 by chr.fritsch, criz: Add libraries support
criz’s picture

criz
he/him
Location Vienna/Austria
CreditAttribution: criz at acolono GmbH commented
Status: Needs review » Fixed

Okay, committed. Thanks. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.