There has been coding standard issue.

refer: https://pareview.sh/node/478

Comments

harsha012 created an issue. See original summary.

harsha012’s picture

Status: Active » Needs review
StatusFileSize
new42.5 KB

Added patch

harsha012’s picture

StatusFileSize
new128.9 KB

added patch

harsha012’s picture

StatusFileSize
new154.33 KB
miro_dietiker’s picture

Status: Needs review » Postponed

There are so many pending issues with needs review patches. This is not the right time to do coding standard fixes.
All other patches would be broken.

greg boggs’s picture

Thanks for your help trying to triage issues. If you have the time, helping us review some of the waiting patches would be great. Given the popularity of the module, we almost always have 10 or more issues waiting for review. As our entire team are git experts, rerolls needed because of coding standards improvements won't be a problem.

greg boggs’s picture

Assigned: harsha012 » Unassigned
Status: Postponed » Needs review
miro_dietiker’s picture

@Greg Boggs we usually commit code clean-ups right after or short before tagging a release. Core did so in a code freeze phase. No matter how experienced you are, committing an issue like this breaks patches and you not only need to reroll issues, but also wait for the bot to pass to commit things, right. These situations slow me down with reviews and are IMHO a waste of time. But hey, thx for your great maintenance work and glad you want to handle this pain. I like clean code too! :-)

greg boggs’s picture

I hear you for sure. I've been putting this one off until the next release is done which I'm doing this week. After that, I plan to get the code cleanup done like a band aid.

samuel.mortenson’s picture

Assigned: Unassigned » samuel.mortenson
samuel.mortenson’s picture

StatusFileSize
new214.33 KB

  • samuel.mortenson authored c01d531 on 8.x-1.x
    Issue #2837714 by harsha012, samuel.mortenson: code clean up as per...
samuel.mortenson’s picture

Status: Needs review » Fixed

The queue isn't completely clean but now is as good a time as any to get this in. Thanks for the patience all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.