Add an option to suppress page not found watchdog messages

Did some quick research, looks like the best way to do this is to add a decorator for the logger factory and return a null logger for the page not found channel.

1. +++ b/modules/redirect_404/config/schema/redirect_404.schema.yml
   @@ -9,3 +9,6 @@ redirect_404.settings:
   +      label: '404 logged messages to be suppressed.'
   

   this label can be improved: Whether to log page not found messages to the standard log or not

2. +++ b/modules/redirect_404/redirect_404.module
   @@ -49,6 +51,13 @@ function redirect_404_form_redirect_settings_form_alter(&$form, FormStateInterfa
   +    '#title' => t('Suppress 404'),
   

   Suppress "page not found" log messages

3. +++ b/modules/redirect_404/redirect_404.module
   @@ -49,6 +51,13 @@ function redirect_404_form_redirect_settings_form_alter(&$form, FormStateInterfa
   +    '#description' => t('404 logged messages to be suppressed, which are not needed for redirect_404 to run. Enable this setting if your site gets a lot of 404 requests.'),
   

   Prevents page not found log messages, can be safely enabled when this module is used which stores them separately and nothing else relies on those messages.

4. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +
   +/**
   + * Suppresses logged 404 messages that are not needed for redirect_404 to run.
   + */
   

   that it can is not really an important information here. I'd write "Allows page not found log messages to be suppressed by returning a NullLogger".

5. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +class Redirect404SuppressLogger extends LoggerChannelFactory {
   

   Redirect404LogSuppressor?

6. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +    $this->logger = $logger;
   

   use loggerChannelFactory and $logger_channel_factory.

7. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +    $this->config = $config->get('redirect_404.settings');
   

   error logging can happen very early, we don't know for sure that the config is readable and so on. It might also not be needed.

   just assign this as $configFactory only read the config in case we have a page not found $channel request.

8. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +    if ($this->config->get('suppress_404') && $channel == 'page not found') {
   +      // Do not log if the suppress_404 is enabled and a 404 error is detected.
   +      return new NullLogger();
   +    }
   

   the the order then and read from $this->configFactory->get()...

9. +++ b/modules/redirect_404/src/Render/Redirect404SuppressLogger.php
   @@ -0,0 +1,63 @@
   +  public function addLogger(LoggerInterface $logger, $priority = 0) {
   +    parent::addLogger($logger, $priority);
   +  }
   

   this is weird, because there will then be two different instances, ourself with the parent and the inner.

   Do not extend, only implement the interface. And call $this->loggerChannelFactory instead.

10. +++ b/modules/redirect_404/src/Tests/Redirect404SuppressLoggerTest.php
    @@ -0,0 +1,86 @@
    +    // Create users with specific permissions.
    +    $this->adminUser = $this->drupalCreateUser([
    +      'administer redirects',
    +      'administer redirect settings',
    +      'access site reports',
    +      'access content',
    +      'bypass node access',
    +      'administer site configuration',
    +      'access administration pages',
    +      'administer users',
    +    ]);
    +    $this->webUser = $this->drupalCreateUser([]);
    

    we can probably skip a good amount of those permission as we don't need the dblog UI.

11. +++ b/modules/redirect_404/src/Tests/Redirect404SuppressLoggerTest.php
    @@ -0,0 +1,86 @@
    +    $this->assertEqual(db_query("SELECT COUNT(*) FROM {watchdog} WHERE type LIKE 'page not found'")->fetchField(), 1);
    +    $this->assertEqual(db_query("SELECT COUNT(*) FROM {watchdog} WHERE type LIKE 'access denied'")->fetchField(), 1);
    

    no need to use LIKE

That interdiff was pretty useless :)

Changes look good though, committed.