Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2016 at 18:38 UTC
Updated:
26 Feb 2017 at 12:34 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
visabhishek commentedUpdating Title based on project page available code version : https://www.drupal.org/sandbox/memsource/2832348
Comment #4
visabhishek commentedAfter cloning code i found the code is in version 8, but Branch name is 7.x-1.x.
Please update it to 8.x-1.x
Comment #5
filip.rachunek commentedComment #6
filip.rachunek commentedSorry, I must have read and outdated documentation. The code is in
8.x-1.xbranch now.Thanks for your time.
Comment #7
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxmemsource2832348git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
filip.rachunek commentedI have fixed all errors and warnings reported by automated review tools.
There are just 3 warnings left (Line exceeds 80 characters) from README.md which are caused by long URLs.
Comment #10
filip.rachunek commentedComment #11
vonovak commentedI went through the code & checklist and it LGTM
reviewed & tested by the community
Comment #12
vonovak commentedComment #13
filip.rachunek commentedHello guys, is there anything new? There was no activity for more than a month. I know that the things would be faster if I review other plugin applications first, but I am no PHP expert, so my evaluations would be far from perfect. Isn't there another way?
We would be very grateful if our plugin is approved soon because some of our clients are desperately waiting for it. Thanks for any help.
Comment #14
hestenetAs this issue is RTBC, I've granted @memsource the git vetted role.
@memsource - you may now promote your sandbox project to a full project and make releases.
One note: Per our terms of service, we require that the accounts which make commits to a project be *individual* accounts. I'd suggest you edit the account you used to make this project and commits to be your individual account, and create a new account to represent your company. https://www.drupal.org/terms (see Section A, parts 2 and 3)
Comment #15
klausiAssigning issue credits.