Problem/Motivation

Media in core will require icons and those icons will need to be SVGs in multiple colors available in core/misc/icons for other modules to use.

Proposed resolution

Determine which icons and make the needed files.

Remaining tasks

  • make files
  • Make patch to add to core

User interface changes

Icons!

API changes

?

Data model changes

?

CommentFileSizeAuthor
#10 icons_not_folded.png69.87 KBdmsmidt
#8 Screen Shot 2016-12-13 at 5.13.45 PM.png19.12 KBtkoleary
#7 file-icons.zip171.91 KBtkoleary
#3 file-type-icons.jpg43.03 KByoroy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tkoleary created an issue. See original summary.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: +visual design
yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: -visual design +Needs design
FileSize
file-type-icons.jpg43.03 KB

If you download https://www.drupal.org/project/media/releases/8.x-1.x-dev you will find an icons folder with:

application-msword.png
application-pdf.png
application-rtf.png
application-vnd.ms-excel.png
application-vnd.ms-powerpoint.png
application-vnd.oasis.opendocument.spreadsheet.png
application-vnd.oasis.opendocument.text-template.png
application-vnd.oasis.opendocument.text.png
application-vnd.openxmlformats-officedocument.presentationml.presentation.png
application-vnd.openxmlformats-officedocument.spreadsheetml.sheet.png
application-vnd.openxmlformats-officedocument.wordprocessingml.document.png

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt at Triquanta commented

Should we think about different sized icons?

Of course SVG scales nicely, but for a tiny icon you also want less details.

So for example in a list mode you would need tiny icons with low detail. And in a thumbnail mode (in cases we can't generate a thumbnail) you can use a bigger version with more detail.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
Assigned: Unassigned » tkoleary
tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented

Summary of comments in UX meeting:

  • Should they be colors? -raises accessibility issues with colorblindness
  • What about different sizes? -don't need special sizes for SVGs since they scale but we will need to test legibility at small sizes.
  • Can we programmatically generate? -Nice-to-have, make an issue for a feature request
  • Where will they be? -In core misc icons in all the colors
  • Where will they be used? -in place of thumbnails in library/browser when no thunbnail exists, and in upload widget and downloads if needed.
  • Could we also make an icon API, better way to generate and discover them? -yes but not MVP
tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
FileSize
file-icons.zip171.91 KB

Here's a zip with the first round. Can be resized if needed.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
Issue summary: View changes
FileSize
Screen Shot 2016-12-13 at 5.13.45 PM.png19.12 KB

They look like this (the bebebe versions)

Of course there are a bunch more of them, around 30.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt at Triquanta commented

I like the progress here.

One thought to disrupt: "Why is the default icon shape a paper with a folded corner"?
I know it is very véry common to do so, and I guess most ppl understand. But it actually only covers "documents" and maybe images (although I would never want my pictures to be folded).

None folded example by EpicCoders:
EpicCoders

Another thought: "What kind of icon will be used as fallback?"
So in cases we don't have an icon for the given media type, what will we show?

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt at Triquanta commented
FileSize
icons_not_folded.png69.87 KB
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented

It seems that we are thinking really file-centric. We should note that we're planning to support YouTube videos out of the box and that there are other "remote" media types that might be supported with the current approach (oEmbed). Icons should reflect that fact.

I also think that mime types aren't very important. Instead exposing file extensions on icons we should better represent general meaning of a media item an icon represents (image, audio, video, document, ...).

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

abbym’s picture

abbym CreditAttribution: abbym at Third and Grove commented

Per comment 11 (slashrsm), I agree that we may want to indicate things such as video or audio as well as classic file types. What if, instead of icon images, we used a custom icon font that could easily be added to over time as needed? That would eliminate concerns about size and color/contrast. If deemed appropriate, we could even add other useful icons such as social media share buttons.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Active » Needs review

Any update through last 3 years? Thank you.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

charly71’s picture

charly71 CreditAttribution: charly71 commented

+1

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Component: Seven theme » Olivero theme
Status: Needs review » Needs work

There's no patch to review.

Also seven has been removed in D10 so if still a valid task it will need to be (if needed) for the newer theme.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.