The Payment entity storage should provide a loadForOrder or some named method for loading payments that belong to an order.

CommentFileSizeAuthor
#2 paymentstorage_should-2831914-2.patch1.88 KBmitrpaka

Comments

mglaman created an issue. See original summary.

mitrpaka’s picture

mitrpaka commented
Status: Active » Needs review
StatusFileSize
new paymentstorage_should-2831914-2.patch1.88 KB

Initial and simple approach below.

PR: https://github.com/drupalcommerce/commerce/pull/634

  • bojanz committed 239a973 on 8.x-2.x authored by mitrpaka 
    Issue #2831914 by mitrpaka, mglaman: PaymentStorage should provide a...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Implemented the following feedback:
1) loadForOrder should be loadForMultipleOrder, for consistency
2) The payment storage needs to implement the new interface
3) We should use the method somewhere (ideally on the list builder)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.