Cannot delete Payment method

Which gateway are you using? The delete code is gateway specific.

jpdaut, was it removed in Authorize.net?

The Authorize.net module has

  /**
   * {@inheritdoc}
   *
   * @todo Needs kernel test
   */
  public function deletePaymentMethod(PaymentMethodInterface $payment_method) {
    $owner = $payment_method->getOwner();
    $customer_id = $owner->commerce_remote_id->getByProvider('commerce_authnet_' . $this->getPluginId());
    $request = new DeleteCustomerPaymentProfileRequest($this->authnetConfiguration, $this->httpClient);
    $request->setCustomerProfileId($customer_id);
    $request->setCustomerPaymentProfileId($payment_method->getRemoteId());
  }

bojanz, I had no idea we needed to delete the payment method in our gateway.

Wouldn't it be best to modify

    try {
      $payment_gateway_plugin->deletePaymentMethod($payment_method);
    }
    catch (PaymentGatewayException $e) {
      drupal_set_message($e->getMessage(), 'error');
      return;
    }
</doe>

to run <code>$payment_method->delete();

after invoking the gateway plugin? I assumed the delete was just to process deletion of the remote profile. And if no exception is thrown the payment method deletes.

Eh, I just read the docblock. Both the entity and the remote record are deleted.

And create method assumes it'll be saved. So I guess we can move this to Auth.net queue and fix there.

Here is patch to fix delete payment method

Revised patch to handle record not found error.