Problem/Motivation

Move potentual functions in .module and .inc files which are candidates for services to the services.yml. Hook implementations are the exception, they can remain in .module, but can use services to do the work.

Remaining tasks

Comments

zerolab created an issue. See original summary.

OlgaRabodzei’s picture

OlgaRabodzei commented
Assigned: Unassigned » OlgaRabodzei

Partly resolved.
In progress.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Assigned: OlgaRabodzei » Unassigned
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

I created child issue from this one. See: https://www.drupal.org/project/conditional_fields/issues/3217413

ressa’s picture

ressa
he/him
commented
Issue summary: View changes

Does the completion of #3217413: Move all conditional_fields_element_after_build logic to a service March 2022 mean that this parent issue is also done, or do we need to create and fix more child issues?

I have added a "Remaining tasks" section in the Issue Summary, for any additional tasks.

sokru’s picture

sokru commented

Even the module has been on alpha, its Drupal 9+ branch has over 25k active installs, so I created a draft for change notice the site builders / developers might face with this update.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Issue summary: View changes
Status: Active » Needs review

Not sure why this issue links to a github fork of this project and the link to the issue comment is dead. Apart from that not all can be moved to services and this needs to be addressed in more detail instead of quoting an issue comment from github (removed/edited).

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Fixed

From taking a look into the list of already registered services and into the .module with 99% hooks, I think it can be closed. At least for the upcoming beta1 release. Feel free to re-open if you think there are left-overs to be moved over too for beta2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.