Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Move potentual functions in .module and .inc files which are candidates for services to the services.yml. Hook implementations are the exception, they can remain in .module, but can use services to do the work.
Remaining tasks
- #3217413: Move all conditional_fields_element_after_build logic to a service
- Add more child issues?
Comments
Comment #2
OlgaRabodzei CreditAttribution: OlgaRabodzei at Adyax commentedPartly resolved.
In progress.
Comment #3
colanComment #4
paulocsI created child issue from this one. See: https://www.drupal.org/project/conditional_fields/issues/3217413
Comment #5
ressa CreditAttribution: ressa at Ardea commentedDoes the completion of #3217413: Move all conditional_fields_element_after_build logic to a service March 2022 mean that this parent issue is also done, or do we need to create and fix more child issues?
I have added a "Remaining tasks" section in the Issue Summary, for any additional tasks.
Comment #6
sokru CreditAttribution: sokru as a volunteer commentedEven the module has been on alpha, its Drupal 9+ branch has over 25k active installs, so I created a draft for change notice the site builders / developers might face with this update.
Comment #7
dqdNot sure why this issue links to a github fork of this project and the link to the issue comment is dead. Apart from that not all can be moved to services and this needs to be addressed in more detail instead of quoting an issue comment from github (removed/edited).
Comment #8
dqdFrom taking a look into the list of already registered services and into the .module with 99% hooks, I think it can be closed. At least for the upcoming beta1 release. Feel free to re-open if you think there are left-overs to be moved over too for beta2.