[D7] Instapage Module [#2829972]

Link to sandbox project: https://www.drupal.org/sandbox/instapage/2823680
The intended Drupal core version: 7.x and 8.x

This is an official Instapage Drupal module (https://help.instapage.com/hc/en-us/articles/207038297-Publishing-Your-P.... Links are already published in our help center). Previous version of Drupal module was maintained by 3rd party company (https://www.drupal.org/project/instapage). We created a new version of Instapage Drupal module to add new features, develop new versions faster, secure better issue tracking and to enable instant communication between our teams responsible for app and our plugin network.

The core part of the plugin doesn't follow Drupal coding standard because it's in fact a foundation for a network of plugins to all major PHP based CMS-es. We are supporting Drupal 7, Drupal 8 and Wordpress at the momemt.

Inspapage module is used to publish landing pages built in app.instapage.com via Drupal. First connect your page to your Instapage account. You can do this on settings tab of module's dashboard at /admin/structure/instapage_cms_plugin.

You will have to enter username and password of your Instapage account or use your Instapage Token.

After you successfully connect, you can see all your pages from Instapage (if you used Instapage credentials as a login method) or pages from subaccount bound with tokens you used.

Keep in mind that the pages will only show up if you publish them for Drupal on Instapage administration pages.

After you get a list of the pages you can put in the path for each of them and publish them as a regular page, home page or 404 page.

Comments

Comment #1

23 November 2016 at 14:26

instapagedev created an issue. See original summary.

Comment #2

instapagedev commented 23 November 2016 at 14:33

Assigned:

instapagedev

» Unassigned

Comment #3

PA robot commented 23 November 2016 at 17:23

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #4

patilvishalvs commented 1 December 2016 at 07:29

Hi,

Please review your code on "https://pareview.sh" site. I found some errors and warnings in your code. Given below is the link:

https://pareview.sh/node/238

Comment #5

sourabh.singhal commented 5 December 2016 at 07:25

Hi instapagedev,

I have installed this module and have done some manual code review and here is my findings:

There should be a git clone URL on Project application issue page, anyways it's non-blocking issue, still it is recommended.
In module file, there should be a file doc comment which describe the purpose of including "instapage.php" file. [non-blocking] issue, still recommended.
In module file, you can use hook_help() for the module help page, which helps end user to understand the module usability.
In .info file, you have defined "configure = admin/config/services/instapage_cms_plugin", on module page i.e.(admin/modules), the configure link next to your module redirected to the "/admin/config/services" which is different from the URL mentioned in info file. Kindly fix this too.

Thanks
Sourdrup

Comment #6

sourabh.singhal commented 5 December 2016 at 07:28

Status:

Needs review

» Needs work

Comment #7

klausi

he/him||they/them

German

🇦🇹 Vienna

commented 5 December 2016 at 08:47

Status:

Needs work

» Needs review

@sourdrup: those are good tips but surely not application blockers. Anything else that you found or should this be RTBC instead?

Comment #8

instapagedev commented 6 December 2016 at 15:16

Thank you for the first reviews. We will apply fixes APAP.

Comment #9

sandip27 commented 14 December 2016 at 10:59

Status:

Needs review

» Needs work

Hello @instapagedev

I reviewed the module and found few issues in it.

1. In log.php file, ample of variables are used but not defined/declared. Would have been great if did so. Surely, not a blocker but good to do so.

2. You could prepend project name to the class names in files, ViewModel.php or SubaccountModel.php etc. It would help to make it unique and non-conflicting.

3. README.txt file has few spelling mistakes, viz., succesfully, beeing etc Please fix those.

Thanks

Comment #10

PA robot commented 4 January 2017 at 17:26

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #11

instapagedev commented 1 February 2017 at 16:14

Status:

Closed (won't fix)

» Needs review

Issues reported in review process are fixed in v7.x-3.14

Comment #12

PA robot commented 1 February 2017 at 17:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxinstapage2823680git

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #13

PA robot commented 22 February 2017 at 17:25

Status:

Needs work

» Closed (won't fix)

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #14

instapagedev commented 10 March 2017 at 17:06

Status:

Closed (won't fix)

» Needs review

Unused variables were removed. phpdoc comments were added for all classes and methods. Issues left in automatically generated report:

False positives like undeclared variables in template files. Proper comments were added, those variables are declared in a file that uses the template.
Coding style issues in core plugin files. We can't use Drupal coding style in the plugin. It's not meant for Drupal only. Currently, the same core files are used by Drupal 7, Drupal 8 and WordPress. More PHP CMSes will be supported by the same core files in near future. That's why we are using coding style adopted in the company, not the one preferred by Drupal.
Coding style issues in libraries used by the plugin. We don't change original coding style of the libraries that are used by the plugin (knockout.js, UI Kit)
Coding style issues in phpdoc comments. We use the style of phpdoc comments adopted by the Instapage company. it's based on phpDocumentor documentation.

Comment #15

instapagedev commented 3 April 2017 at 17:08

There were no more reported issues since 24 days. Is there anything else we can do to push the plugin out of the sandbox? Our clients would appreciate the opportunity to get regular updates.

Comment #16

instapagedev commented 4 May 2017 at 14:53

Could somebody reply to our request? I commented 2 months ago, no feedback ever since. Please report the issues to fix or move the project out of the sandbox. I'm constantly getting tickets for easier plugin update from our clients.

Comment #17

Ravi Cmsminds commented 1 July 2017 at 10:37

I checked your module, however there are issues and recommendations that you may be interested in :

FILE: /root/repos/pareviewsh/pareview_temp/src/Routing/PagesRoutes.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
15 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------

FILE: ...s/pareviewsh/pareview_temp/src/Controller/PageSettingsController.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
14 | ERROR | [x] Doc comment short description must end with a full
| | stop
15 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
26 | ERROR | [ ] Missing parameter comment
27 | ERROR | [ ] Missing parameter comment
35 | ERROR | [ ] Missing short description in doc comment
36 | ERROR | [ ] Missing parameter comment
49 | ERROR | [ ] Description for the @return value is missing
62 | WARNING | [ ] Avoid backslash escaping in translatable strings
| | when possible, use "" quotes instead
69 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
74 | WARNING | [ ] Avoid backslash escaping in translatable strings
| | when possible, use "" quotes instead
110 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.links.menu.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.permissions.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
11 | WARNING | Hook implementations should not duplicate @param
| | documentation
11 | ERROR | Missing parameter comment
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 85 characters
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.libraries.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/config/instapage.settings.yml
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
2 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.install
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
5 | ERROR | [x] The second line in the file doc comment must be "@file"
8 | ERROR | [x] There must be no blank lines after the function comment
12 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
13 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
30 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
42 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/instapage.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------

Comment #18

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 1 June 2018 at 09:55

Status:

Needs review

» Postponed (maintainer needs more info)

Thank you for your contribution!

Looking at the list of the committers, I see there are users who aren't listed as maintainers. Did you clone another project? If the answer is yes, which project did you clone?

Comment #19

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 25 November 2018 at 10:54

Status:

Postponed (maintainer needs more info)

» Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity. (The comment reporting what to fix in the code has been written on July, 2017.)

[D7] Instapage Module

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

News items

Our community

Documentation

Drupal code base

Governance of community