The current selectors for elements that are editable by Outside In in outside_in.motion.css are not scoped to apply only when Outside In is enabled (in edit mode).

As a result, these rules are always applied which makes things like drag and drop using Panels IPE extremely slow. This patch simply scopes the selectors down so that they only apply when Outside In is enabled, which makes sense as this is the only time the hover styles for Block Plugins are applied.

CommentFileSizeAuthor
#9 outside-in-motion-scope-block-selectors.patch-reupload.patch758 bytestedbow
outside-in-motion-scope-block-selectors.patch758 bytessamuel.mortenson

Comments

samuel.mortenson created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

This looks good. Tested it. Small change. So RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, outside-in-motion-scope-block-selectors.patch, failed testing.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Strange non-related test error. Re-testing

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Reviewed & tested by the community

Testbot failure, resetting status due to https://www.drupal.org/node/2828045

Status: Reviewed & tested by the community » Needs work

The last submitted patch, outside-in-motion-scope-block-selectors.patch, failed testing.

tkoleary’s picture

tkoleary commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, outside-in-motion-scope-block-selectors.patch, failed testing.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new outside-in-motion-scope-block-selectors.patch-reupload.patch758 bytes

Something is stuck with the testbot. Reuploading @samuel.mortenson's patch

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

Setting back to RTBC as this is the same patch as that was RTBC'ed on #2

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Feature request » Bug report
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2c0f882 to 8.3.x and b66cc86 to 8.2.x. Thanks!

This ain't a feature :)

  • alexpott committed 2c0f882 on 8.3.x 
    Issue #2826763 by tedbow, samuel.mortenson: Outside In motion selectors...

  • alexpott committed b66cc86 on 8.2.x 
    Issue #2826763 by tedbow, samuel.mortenson: Outside In motion selectors...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)