PHP notices on PHP 5.6

Thanks @jenlampton. The code in question fetches the state labels using the function workbench_moderation_state_labels. It's iterating over each of the states' transitions. I'll try to reproduce the issue. Could you provide me with a screenshot of your configuration for workbench_email and workbench_moderation states and transitions?

Thank you. That's odd, the two transitions "illustrate" and "copy_edit" don't seem to be presented in the moderation screen. I've got a hunch that the workbench_emails table may still have the email settings for those two transitions/states in it's own table.

If you have access to the database could you do a quick query of that table and provide a screenshot?

If my above hunch is correct, we'll need to figure out why those records weren't purged.

Hi @jenlampton,

Do you have a status update on this issue? Or were you able to resolve this issue?

When a user deletes some workbench-mod states, then workbench-email should delete all sets where from/to_name is not anymore a state. Perhaps it is a good idea to add a update hook to do this also.

Remove also sets with invalid roles.

Thanks tobiasb,

I've reworked the function workbench_email_delete and made use of hook_workbench_moderation_state_delete and hook_workbench_moderation_transition_delete to delete the necessary email templates.