This module basically alters all the login links in a site adding the destination param with the current page as value.

This let the users come back to the current page after they logged in the site.

git clone command:
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/gnuget/2824414.git

CommentFileSizeAuthor
#8 2824418-7-login_return_page.patch1.17 KBgnuget
#5 login_page_error.png54.37 KBaloknarwaria

Comments

gnuget created an issue. See original summary.

PA robot’s picture

PA robot commented
Status: Active » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

gnuget’s picture

gnuget
Primary language Spanish
commented
Issue summary: View changes
gnuget’s picture

gnuget
Primary language Spanish
commented
Issue summary: View changes
aloknarwaria’s picture

aloknarwaria commented
StatusFileSize
new login_page_error.png54.37 KB

Destination is not required on login page please find the attachment to fix the issue.

sarthak drupal’s picture

sarthak drupal commented
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Needs review

Hi! @Aloknarwaria.

I pushed a new change to my repo with the following patch.

Thanks!

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 2824418-7-login_return_page.patch1.17 KB
PA robot’s picture

PA robot commented
Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

gnuget’s picture

gnuget
Primary language Spanish
commented
Issue summary: View changes

Done :-)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This module is not necessary, fixing this core bug is: #2582797: [Regression] login link has no destination=drupalSettings.path, so dumps you on the profile.

gnuget’s picture

gnuget
Primary language Spanish
commented

Hi Wim Leers.

It is good to know.

I will check the issue to see if I can help to fix it.

Thanks!

virajrajankar’s picture

virajrajankar commented
Status: Needs review » Needs work

@gunget:
Still there are some issues in "pareview.sh" , other than that module looks good.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Postponed

Thanks for your review @virajjankar.

But I will try to focus in fix the core issue instead to continue working on this module. :-)

I will postpone this issue in the meanwhile.

Regards.

PA robot’s picture

PA robot commented
Status: Postponed » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.