This test generate page like this http://prntscr.com/czl160
and check the following $this->assertText($this->t('Successfully executed @count pending task.', array('@count' => 1)));

CommentFileSizeAuthor
#7 2822553-7--dummy_patch.patch571 bytesdrunken monkey
#2 remove-unnecessary-assertText-search_api-integratin-test-2822553-2.patch601 bytesniko-

Comments

niko- created an issue. See original summary.

niko-’s picture

niko- commented
StatusFileSize
new remove-unnecessary-assertText-search_api-integratin-test-2822553-2.patch601 bytes
niko-’s picture

niko- commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

I don't see why tis is unnecessary. Our tests all seem to pass with it. Not sure if we should do this tbh.

niko-’s picture

niko- commented

Not sure if this issue is right.

Please check http://prnt.sc/czl160
There is no message "Successfully executed @count pending task." on it.
But in original test we have checked if it available

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

In that case, instead of changing the test, we should probably figure out why it's not showing up in your case and fix that.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2822553-7--dummy_patch.patch571 bytes

Hm, no, this indeed seems to fail consistently when the tests are run via the GUI (since that will not use a batch to execute those tasks, thus also not producing that message). Since we afterwards check the number of tracked items, which also asserts that the tasks were executed (whether via batch or directly), I'd say getting rid of that assert really does seem like a sensible option. Or does anyone have a better suggestion?
(We could, of course, skip the assert just when running via the GUI, but I don't think that's a good pattern to fall into.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Oops, didn't mean to attach that – first created the patch, but then figured out the problem without it anyways.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Sure, thanks for explaining that @drunken monkey!

  • drunken monkey committed 0c83ac6 on 8.x-1.x authored by niko- 
    Issue #2822553 by niko-: Removed a test assertion that failed when run...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Committed.
Thanks again for reporting this, niko-!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.