hook_help() is missing for the module.
Adding help page will be helpful for people using this module.

CommentFileSizeAuthor
#4 interdiff.txt3.62 KBprashant.c
#4 add-help-page-2822176-4-8.x-1.x-dev.patch4.47 KBprashant.c
#2 add-help-page-2822176-2-8.x-1.x-dev.patch4.59 KBprashant.c

Comments

Prashant.c created an issue. See original summary.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Title: Add help text for the module » Add help page for the module
Status: Active » Needs review
StatusFileSize
new add-help-page-2822176-2-8.x-1.x-dev.patch4.59 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work 
+++ b/eu_cookie_compliance.module
@@ -182,3 +183,42 @@ function eu_cookie_compliance_validate_hex($element, FormStateInterface &$form_s
+      $output .= '<p><code>' . t('Drupal.eu_cookie_compliance.hasAgreed()') . '<\/code></p>';
...
+      $output .= '<p><code>' . t('php ./core/scripts/run-tests.sh --color --verbose --browser --url <http://example.com> --class "\Drupal\eu_cookie_compliance\Tests\EuCookieComplianceTest"') . '<\/code></p>';
...
+      $output .= '<p><code>' . t('drupal tr --url=<http://example.com> "\Drupal\eu_cookie_compliance\Tests\EuCookieComplianceTest"') . '<\/code></p>';

Those things in code here should never be translated. Let's remove the t()

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new add-help-page-2822176-4-8.x-1.x-dev.patch4.47 KB
new interdiff.txt3.62 KB

@borisson_

Thanks for figuring out this, made changes mentioned by you along with couple of other.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Changes look good!

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Priority: Normal » Minor

Changing priority

killua99’s picture

killua99 commented
Status: Reviewed & tested by the community » Fixed

Well a little help is always appreciate ;D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.