Views integration

Another thing: I suggest we remove the setting Maximum number of thumbnails per page since that can be changed in Views now. And I think few people change this anyway.

OK, here we go...

The attached patch does most everything outlined above, except providing the ability to add your own views to the thumbnail browser. I thought it would be best to finish the groundwork first and wait for comments – the rest will be trivial.

A few other things remain:

– Showing unpublished images in My images. This is a little tricky as Views doesn't provide a Node: published argument, only a filter. Can we lose this feature? Do people use it? (If not, I think the solution would be to define two separate displays for the default view.)
– Haven't touched any CSS yet.

A note for people who read the patch: I have changed the path scheme from:

img_assist/thumbs/xxxx

to:

img_assist/thumbs/{view_name}/{arg1}/{argN}

Happy reviewing!

Looks good, works great! Made a couple of small changes:
– Views selection showed an empty row if the view title wasn't set. Added a fallback to $view->name.
– Why 3 x 3 images? 6 images (3 x 2) has always been the default, right? Changed back for now.

Thoughts:
– Should we use t() in img_assist.views_default.inc?
– img_assist.views_default.inc is indeed very large, it's a full view export. I'm not sure what parts are required and what can be removed so I would have to remove stuff piece by piece and see if it still works. I noticed that for instance comment.views_default.inc contains a full view export too. Maybe we should leave it as it is.

#3: I think using files as base table would be a little complicated with IA's current connection to Image module, since each image is represented by an arbitrary number of files. Keeping track of different sizes would be tricky too, no?

#4: Agreed. Let's restructure to .inc files after this is done.

Here is a separate patch for img_assist.css – don't want to clutter the main patch with even more changes.

First, let me point out that the IA window looks completely different depending on if you use it with TinyMCE or not. With TinyMCE, we get only TinyMCE's css file and img_assist.css. Without TinyMCE, IA includes all the regular Drupal CSS files including the theme's files – and then img_assist.css. (This is the intended behavior, take a look at theme_img_assist_page().)

In this patch:

– Removed unnecessary declarations.
– Hided .views-admin-links. (This is first and foremost needed with TinyMCE.)
– Added overrides for table styling. Garland for instance adds borders and margins to it's tables which doesn't work well here.
– Centered tables and node forms with margin: auto since we removed <div align="center"> from the markup.

Great stuff!

How about the css patch in #7?

Exposed filters in custom views don't work properly. When you submit the form you get redirected to a Views callback instead of Image assist, hence losing all its specific theming etc. This patch rewrites the #action attribute.

Also snuck in another fix: The Browse select list had an incorrect default value, which meant that most of the time the default would be My images, but it could also be a custom view. However, regardless of this, the bottom frame is always populated by My images by default. (This happens in img_assist.js.) So this patch sets the default to My images.