Closed (fixed)
Project:
Display Suite
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Oct 2016 at 16:36 UTC
Updated:
28 Feb 2017 at 15:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkettComment #3
tim.plunkettComment #4
swentel commentedCool thanks! I guess it's time to open op the 8.x-3.x branch :)
Comment #5
dsnopek@swentel: I'm hoping to update layout_plugin to allow you to use it the way this would be in core, while maintaining BC and deprecating the old ways. So, ideally, we'll be able to commit these changes (or at least most of them) to DS before Drupal 8.3.x is out!
Comment #6
swentel commented@dsnopek - cool sounds good.
Fwiw, if the region patch goes in (again), we need a different branch anyway because we alter Field UI heavily as well to add the region column. My mind tells me I'd be better to use a different branch to track those changes in core while we can keep the 8.x-2.x branch open without having to worry that anything crazy breaks. And 8.x-3.x would have a dependency on core >= 8.3.x and would use layout plugin and field layout from core, so I think that's safe, and necessary, given that both modules in core will be experimental, so subject to change.
Comment #7
tim.plunkettIs this obsolete now?
Comment #8
swentel commentedAlmost, looking at some changes in this patch - why on earth didn't I apply it in the first place ?
Comment #10
swentel commentedOk, only two failures, but that's for another moment, have to run now (https://www.drupal.org/pift-ci-job/549759)
Comment #11
tim.plunkettThe second fail is due to #2559825: Preprocess functions from base hooks not triggered for theme hooks not using the __ pattern / #2834019: Remove the "layout__" prefixing of theme hooks and is temporary, after that is fixed the DS test will pass.
Comment #12
aspilicious commentedI can confirm that one fail is solved by that issue.
There was another one in entitiestest that I have fixed 2 minutes ago.
I'm looking at the others now.
Comment #13
aspilicious commentedI fixed the last fail, but I'm not happy with it.
Region stuff has changed and at the moment the change layout form is hacking around the fact that there is a deeper level for the "label" now.
I hacked some more to fix the warnings but this actually needs a refactoring.
BUT I think everything should be green now when the first linked patch is committed.
Comment #14
aspilicious commentedComment #15
aspilicious commentedFixed, just in time!
Again, thnx for all the help Tim :)