Some of these changes can be made now (switching from css to library in ds.layouts.yml). Some of it is dependent on the core patch, like the new object-based definitions.
Just tracking what work will need to be done.

CommentFileSizeAuthor
#2 2821201-core-2.patch29.86 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

StatusFileSize
new29.86 KB
tim.plunkett’s picture

Title: Update for layout_plugin in core » Update Display Suite for layout_plugin in core
swentel’s picture

Cool thanks! I guess it's time to open op the 8.x-3.x branch :)

dsnopek’s picture

@swentel: I'm hoping to update layout_plugin to allow you to use it the way this would be in core, while maintaining BC and deprecating the old ways. So, ideally, we'll be able to commit these changes (or at least most of them) to DS before Drupal 8.3.x is out!

swentel’s picture

@dsnopek - cool sounds good.

Fwiw, if the region patch goes in (again), we need a different branch anyway because we alter Field UI heavily as well to add the region column. My mind tells me I'd be better to use a different branch to track those changes in core while we can keep the 8.x-2.x branch open without having to worry that anything crazy breaks. And 8.x-3.x would have a dependency on core >= 8.3.x and would use layout plugin and field layout from core, so I think that's safe, and necessary, given that both modules in core will be experimental, so subject to change.

tim.plunkett’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev

Is this obsolete now?

swentel’s picture

Almost, looking at some changes in this patch - why on earth didn't I apply it in the first place ?

  • swentel committed a6d4ce4 on 8.x-3.x authored by tim.plunkett
    Issue #2821201 by tim.plunkett: Update Display Suite for layout_plugin...
swentel’s picture

Ok, only two failures, but that's for another moment, have to run now (https://www.drupal.org/pift-ci-job/549759)

tim.plunkett’s picture

aspilicious’s picture

I can confirm that one fail is solved by that issue.
There was another one in entitiestest that I have fixed 2 minutes ago.
I'm looking at the others now.

aspilicious’s picture

I fixed the last fail, but I'm not happy with it.
Region stuff has changed and at the moment the change layout form is hacking around the fact that there is a deeper level for the "label" now.

I hacked some more to fix the warnings but this actually needs a refactoring.
BUT I think everything should be green now when the first linked patch is committed.

aspilicious’s picture

Issue tags: +drupalmountaincamp
aspilicious’s picture

Status: Active » Fixed

Fixed, just in time!

Again, thnx for all the help Tim :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.