Closed (fixed)
Project:
Simple OAuth (OAuth2) & OpenID Connect
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Oct 2016 at 09:19 UTC
Updated:
10 Jan 2017 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
e0ipsoThis is a fantastic patch! Thank you Ed.
I have some nit picks:
I always forget, is this supposed to be
TRUEor'TRUE'?Json::decode(…)
We should throw an HttpException instead. This is out of the scope of this issue, but … could you create a follow up for someone else to take on?
DCS: else in the next line.
This needs a docblock.
Comment #3
e0ipsoI'm good with this feature request, but we need to figure out a way to make people understand that they can't allow 3rd parties to use this endpoint.
I do not think we can enforce this behavior from the server. We should add some big red signs explaining what this endpoint is used for.
Maybe this endpoint could respond with an error until the admin goes to the UI and "enables" it with a confirmation form.
Context:
Comment #4
ef4 commentedHi Mateu, I only just noticed your feedback (I guess email notification for issues was turned off, but now I figured out how to turn it on).
I came and looked because I saw you tweet about progress on a similar feature -- are you still interested in this one or has it been superceded? I am happy either way. If this patch is still valuable I will make the revisions you suggested.
Comment #5
e0ipsoYes. That tweet was about the version
8.x-2.x. However, I still think this issue has a lot of merit for8.x-1.xso if you address the existing nit picks it would be fantastic.On second read I don't think that we need anything extra regarding:
Comment #6
sylfo commentedHi !
I gave this patch a try. However, I stumble on a HTTP error 500 when sending a POST on /simple-oauth. The apache logs reveals a dependency injection issue :
I'm totally newbie on Drupal/PHP and I can't see what is causing this issue. For info, a POST on /simple-oauth/refresh works fine.
Would you have any clue about this ?
Thanks !
Comment #7
sylfo commentedJust for information, I retried and realized I haven't reloaded Drupal cache (drush cache-reload). The route was not properly registered, leading to the 500 error. With the reload, it now works !
Comment #8
e0ipsoAdded some modifications before merging. Thanks @ef4!