Block.php Undefined index: allow

I got this as well, even with a very simple views block. After investigating I've seen that the function gets called when you are opening the options form for every section in the view config. Checked how the default core views block display plugin works and adjusted the code accordingly. Attached is a patch with the changes.

Reattached to submit for testing.

Removed #5 file from view

This is good but I had to add
if (isset($defaults)) {
$form['allow']['#default_value'] = $defaults;
}
after the switch. when i was trying to switch around 'pagerer' in block controls. Also had trouble applying patch. but got ahead with this (error was that $defaults was undefined after I applied the patch):

Boo hoo trailing whitespace. deleted that line.

not sure why that didn't trigger tests. come on now.

Not sure that's the correct play there. The $defaults are only being set inside the switch statement, so there might be a better way to do this. What were the steps to reproduce your issue?

jzavrl I have not had time to reproduce this, but it was a view with a block and a page. I couldn't get to the view's pager controls popup on the block display ( to switch the pager off, as it was turned on) without getting back ajax 500 errors like those above. Being unclear on the nature of the function I just kept the isset as a separate statement from the switch, but yes I bet they could go together. Just conveying how the patch helped me get around the fatal error successfully, and save the results from the popup.

+++ b/modules/ctools/modules/ctools_views/src/Plugin/Display/Block.php
@@ -47,20 +47,26 @@ public function optionsSummary(&$categories, &$options) {
+        $options['offset'] = $this->t('Pager offset');
+        $options['pager'] = $this->t('Pager type');

Could this array declaration be set out as per DCS https://www.drupal.org/docs/develop/standards/coding-standards#array
Somthing like:

$options = array(
'offset' => $this->t('Pager offset'),
'pager' =>$this->t('Pager type'), ...

Then

 $form['allow']['#options'] = $form['allow']['#options'] + $options;

Punting this to beta2.

Lets bump this so that beta2 can be rolled out.

Tidy up

This was blocking me today so here's a re-roll and an update:

Changed the array declaration as per suggestion by @darrenwh, and as $form['allow']['#options'] is fully overwritten anyway.

Passed testing second time around, seems to have been an issue with the test server

+++ b/modules/ctools_views/src/Plugin/Display/Block.php
@@ -43,20 +43,26 @@ class Block extends CoreBlock {
+         'offset' => $this->t('Pager offset'),

The indentation is slightly off here

The interdiff is giving an error when previewed (Unexpected request?)

Indentation fixed and new interdiff created.

Tested in preproduction and is working as expected.

I'm also getting this error:

Notice: Undefined index: allow in Drupal\ctools_views\Plugin\Display\Block->buildOptionsForm() (line 46...

Whenever I go to edit a block view, even though I'm using ctools 8.x-3.0+3-dev (dated 11 July 2017).

@rvanderh1 This fix hasn't been committed yet, apply the patch in comment #28 and it should resolve the issue.

OK, thanks. The patch resolved the issue. When do you think the fix will be committed?

Patch fixed multiple issues we were having with ajax and editing multiple options inside a block view.

Thanks,

•• matt

Patched fixed multiple issues for me as well I will be glad when this is committed.

+1 RTBC for me too.

#28 solve my problem too...

#28 solve it for me too, would be great if this could be up soon :D

+1 for RTBC. Patch applies cleanly and fixes a number of interface issues.

Thanks for testing this out, I'm looking to commit this but want to check on a small thing.

+++ b/modules/ctools_views/src/Plugin/Display/Block.php
@@ -43,20 +43,26 @@ class Block extends CoreBlock {
+    switch ($form_state->get('section')) {
+      case 'allow':

nit: this should likely be a an if statement don't you think, or is there plans to break off other section's?

@joelpittet good point, I've swapped that for an if statement. If other sections need breaking out in the future, a switch can be implemented then.

Patch from #41 fixed the issue for me (Drupal 8.6.1)

Hello,

Patch from #41 no longer applies cleanly due to this similar issue that was recently committed…

https://www.drupal.org/node/2978750

Thanks,

•• matt

Ah didn't see they were touching, this needs a reroll.

Same here, got ajax error undefined index: allow in Drupal\ctools views\Plugin\Display\Block->buildOptionsForm() ...

#41 seems to fix the issue, if Block.php is unpatched.

Tried to build a combined patch.

Follow the patch!

+++ b/modules/ctools_views/src/Plugin/Display/Block.php
@@ -41,19 +41,19 @@ class Block extends CoreBlock {
-      if (!empty($defaults['items_per_page'])) {
+      if (isset($defaults['items_per_page']) && !empty($defaults['items_per_page'])) {

!empty() does an implicit isset(), so calling isset() before !empty() is a bit redundant.

I've lost track what this patch is fixing, can anybody tell me?

You're right!

On php.net

"empty() is the opposite of (boolean) var, except that no warning is generated when the variable is not set."

So essentially

<?php
if (isset($var) && $var)
?>

is the same as

<?php
if (!empty($var))
?>

doesn't it? :)

!empty() mimics the chk() function posted before.

Follow the patch!

I could see how this could still produce a warning and notice and the patch doesn't seem to fix that possiblitity.

This code $options = $form['allow']['#options']; before copied the allow options passed in (when they exist) and the new code
$form['allow']['#options'] = [...] clobbers any options that are passed in already.

The original issue is Notice: Undefined index: allow

So we could just set those values individually:
$form['allow']['#options']['offset'] = $this->t('Pager offset');

Follow!

@thalles and I can't seem to find where this original notice stems from. Could someone help by letting us know where or at least running across this issue and letting us know if the patch in #53 resolves it?

Thanks for the patch @thalles!

Patch worked for me (Drupal 8.6.10, PHP 7.2) Thx :)

How can I test?

Patch worked for me too!!

Thanks for the patch @thalles!

Drupal 8.6.10, PHP 7.2

@seros-me, how can I test?

@thalles in my case, originally, with "pagerer" module enabled, and a block set to be paginated, i could trigger the error by attempting to disable the pager. Attached to a view was a block and a page. Inside Views UI: I couldn't get to the view's pager controls popup on the block display ( to switch the pager off, as it was turned on) without getting back ajax 500 errors like those above.

@HongPong, after the patch the bug has been fixed?

Ideally it would be nice to know "what" was fixed with this patch but I could imagine. Thanks for helping @thalles, I've committed this to the latest dev release.

Thanks @joelpittet!
Thanks all!

I'm still experiencing this issue as referenced in https://www.drupal.org/project/ctools/issues/3038160. I only get the AJAX error on new views I create on my local, not ones from core.

Undefined index: allow in /Users/digitalechidna/Sites/caaspr/docroot/modules/contrib/ctools/modules/ctools_views/src/Plugin/Display/Block.php on line 57

@eblue this was committed after the most recent release, so it's only fixed in the development branch currently.
You can apply the patch above to fix the issue until there's a new release