Add target to Download Link [#2820690]

As started in the Filefield Target issue queue by mistake #2819217: Add Download File with Target field formatter, is it possible to add a target option to the Download Link formatter. This will allow the file to be opened in a new tab or new window if supported by the browser.

Comment	File	Size	Author
#3	Set_download_target_from_here.png	26.7 KB	silvi.addweb
#3	Download_link_with_target.png	12.24 KB	silvi.addweb
#3	add_target_to_download-2820690-3.patch	4.09 KB	silvi.addweb
#3	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 October 2016 at 09:26

waverate created an issue. See original summary.

Comment #2

waverate CreditAttribution: waverate commented 20 October 2016 at 09:26

Comment #3

silvi.addweb CreditAttribution: silvi.addweb at AddWeb Solution Pvt. Ltd. commented 20 October 2016 at 12:55

Status:

Active

» Needs review

File	Size
add_target_to_download-2820690-3.patch	4.09 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
Download_link_with_target.png	12.24 KB
Set_download_target_from_here.png	26.7 KB

Attached patch solves this issue.

Comment #4

waverate CreditAttribution: waverate commented 21 October 2016 at 13:59

Tejal,

It looks like your patch is being applied correctly. However, there is a subtle difference that I cannot see. In Display 1, the file is opened in a new tab in the browser. In Display 2, the dialog box with the Open and Save options are displayed. Ideally, I would like to have Display 2 opening up in a new tab in the browser.

Display 1. Filefield Target module using formatter: Generic File with Target

<span class="file">
  <img class="file-icon" alt="" title="application/pdf" src="/modules/file/icons/application-pdf.png">
  <a href="http://example.com/sites/default/files/brochure/brochure-woodhaven-phase-1a-subdivision.pdf" type="application/pdf; length=460191" target="_blank">brochure-woodhaven-phase-1a-subdivision.pdf</a>
</span>

Display 2. File Entity with patch #3 using formatter: Download Link

<span class="file">
  <img class="file-icon" alt="" title="application/pdf" src="/modules/file/icons/application-pdf.png">
  <a href="/file/2515/download?token=QWm7wWdF" type="application/pdf; length=460191" target="_blank">Subdivision Brochure</a>
  <span class="file-size">(449.41 KB)</span>
</span>