Problem/Motivation

I spent a fair bit of time yesterday trying to get an embed configuration going with no joy. I'd mistakenly chosen 'modal' in the entity browser display instead of 'iframe'. The 'modal' browser option isn't compatible with Embed.
We should make that known when you're configuring the embed button.

Proposed resolution

When a user selects an entity browser in the 'create embed button' form, check what display plugin it uses. If it uses 'modal' display a warning.

Remaining tasks

Patch
Tests
Reviews

User interface changes

New warning

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2819871-2.patch908 bytesmarcoscano

Comments

larowlan created an issue. See original summary.

marcoscano’s picture

Project: Embed » Entity Embed
Status: Active » Needs review
Issue tags: +D8Media
StatusFileSize
new908 bytes

Perhaps just with an improved description it is enough to make this clear?

As far as I understood, the display plugins may be different in the future, and we should not assume that the only one that will work is iFrame (and Modal the only that won't work). I have tried to extend the description in a way that illustrates this, while still making it clear that they should use iFrame, if in doubt :)

Also, moving this to Entity Embed, once the description there is generated by this module

slashrsm’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

slashrsm’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • slashrsm committed a9f6ea8 on 8.x-1.x authored by marcoscano
    Issue #2819871 by marcoscano: Make it clear that Embed isn't compatible...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dawehner’s picture

I made an additional suggestion on top of this existing issue: #2904091: [entity_browser] Filter out incompatible entity browsers on the configuration form