CommentFileSizeAuthor
#8 use_this_t_instead_of-2817591-8.patch1.64 KBdhruveshdtripathi
#6 use_this_t_instead_of-2817591-6.patch3.61 KBdhruveshdtripathi
#2 t_2817591_1.patch2.29 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new t_2817591_1.patch2.29 KB
nehakhadke’s picture

nehakhadke commented
alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: t_2817591_1.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Needs review
StatusFileSize
new use_this_t_instead_of-2817591-6.patch3.61 KB

Few remaining t() functions replaced with $this->t()

Status: Needs review » Needs work

The last submitted patch, 6: use_this_t_instead_of-2817591-6.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Needs review
StatusFileSize
new use_this_t_instead_of-2817591-8.patch1.64 KB

Giving a try to avoid test fails.

dhruveshdtripathi’s picture

dhruveshdtripathi commented

Replacing t() function with $this->t() in test file was giving test fail. So just replaced them in the RiddlerSettingsForm.php file only.

alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Needs review » Reviewed & tested by the community

I checked it. And patch #8 working correct.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

+1

alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Reviewed & tested by the community » Patch (to be ported)

  • alex_optim committed 46c568c on 8.x-1.x 
    Issue #2817591 by dhruveshdtripathi, alex_optim, pifagor : Use ->t...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.