It seems more than 100+ sites using this module, but only dev version is available. Why is it that? I do not see any release blockers. Drupal 6 is unsupported, so providing an upgrade from 6.x version should not be a release blocker either. Because this module provides access control for contents it would be wise to release a stable version as soon as possible to get support for security issue from Drupal Security Team.

@see https://www.drupal.org/security-advisory-policy

CommentFileSizeAuthor
#4 og_access_roles-stable_release_2816481-4.patch9.63 KBmxr576
#2 og_access_roles_stable_release_2816481-2.patch9.43 KBmxr576

Comments

mxr576 created an issue. See original summary.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new og_access_roles_stable_release_2816481-2.patch9.43 KB

I've made some coding standards and logic fixes.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review

Lemme fix myself :)
https://www.drupal.org/node/2816547

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new og_access_roles-stable_release_2816481-4.patch9.63 KB

Another issue which needs to be fixed before the stable release. I haven't created a new issue for this with separate patch, because my modifications uses constants which renamed in this issue.

Background story

I have a group, but I haven't assigned a "Group Visibility Roles" field to it. However, I have added a "Group Content Visibility Roles" field to one of its group content. (The module allows this, I do not see any reasons why I should not have done that, besides this is an important point one of our feature requests.)
Then I have created a group with private visibility and after that I've added a group content, where I've selected "Groups Content Visility: Use groups default" and then I've selected a custom role in "Group Content Visibility Roles".

Problem

Because my group does not have "Group Visibility Roles" field, the current implementation of og_access_roles_node_access_records() returns empty roles when I'm creating a group content with the settings that I've mentioned above therefore users with the custom role that I've selected do not get access to the group content.